refactor: unify repo command handling in cli and builder#1677
Conversation
Consolidate duplicate repo subcommand logic from ll-cli and ll-builder into linglong::common::cli (with addRepoCommand, handleRepoCommand) using a RepoConfigBackend abstraction for config access and add unit tests. Signed-off-by: reddevillg <reddevillg@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: reddevillg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the repository management commands in ll-builder and ll-cli by extracting the common CLI subcommand definition and handling logic into a shared module under libs/linglong/src/linglong/common/cli/repo. It also adds corresponding unit tests to verify the shared functionality. Feedback on the changes suggests utilizing CLI11's built-in deprecated() method for the deprecated modify subcommand, improving URL validation to explicitly check for http:// or https:// prefixes, and replacing the magic number 100 used for priority boosting with a named constant.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
3 participants
Consolidate duplicate repo subcommand logic from ll-cli and ll-builder into linglong::common::cli (with addRepoCommand, handleRepoCommand) using a RepoConfigBackend abstraction for config access and add unit tests.