fix: make tests pass without /etc/localtime#1680
Conversation
Handle ENOENT from std::filesystem::symlink_status() when resolving /etc/localtime, so the existing UTC fallback is reachable in clean Arch build chroots where /etc/localtime is absent.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: felixonmars The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @felixonmars. Thanks for your PR. I'm waiting for a OpenAtom-Linyaps member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Code Review
This pull request updates the 'RunContext::resolveTimeZone' method in 'run_context.cpp' to handle cases where the local time file does not exist. Specifically, if 'std::filesystem::symlink_status' returns a 'no_such_file_or_directory' error, the timezone is defaulted to "UTC" and the function returns successfully instead of failing. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Handle ENOENT from std::filesystem::symlink_status() when resolving /etc/localtime, so the existing UTC fallback is reachable in clean Arch build chroots where /etc/localtime is absent.