fix: preserve installed modules on package upgrade/downgrade#1705
Conversation
When upgrading or downgrading a package via command install, only the modules explicitly requested by the user were installed, so previously installed modules (e.g. develop) were silently dropped from the new version. Collect the locally installed modules from the old reference and include them in the install set so they are carried over to the new version. Signed-off-by: reddevillg <reddevillg@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the RefInstallationAction::install process to ensure that during upgrade or downgrade operations, any previously installed local modules are retained and requested for installation. It also introduces deduplication logic when building the list of modules to install. Corresponding unit tests have been added to verify that downgrades keep installed modules and correctly deduplicate runtime fallbacks. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengbo11, reddevillg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
When upgrading or downgrading a package via command install, only the modules explicitly requested by the user were installed, so previously installed modules (e.g. develop) were silently dropped from the new version. Collect the locally installed modules from the old reference and include them in the install set so they are carried over to the new version.