fix: when enable rate limiter auto tune, bandwidth should be higher a…#3093
Merged
Conversation
…s upper bound. fix #3084
WalkthroughThe configuration logic for the rate limiter was updated so that when the "rate-limiter-auto-tuned" option is enabled, the rate limiter bandwidth is forcibly set to 10 GB/s, overriding any previously set or default value. No changes were made to public interfaces or exported declarations. Changes
Assessment against linked issues
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/pika_conf.cc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build_on_macos
- GitHub Check: build_on_ubuntu
- GitHub Check: build_on_centos
- GitHub Check: Analyze (go)
Mixficsol
reviewed
Jun 16, 2025
| GetConfStr("rate-limiter-auto-tuned", &at); | ||
| rate_limiter_auto_tuned_ = at == "yes" || at.empty(); | ||
| // if rate limiter autotune enable, `rate_limiter_bandwidth_` will still be respected as an upper-bound. | ||
| if (rate_limiter_auto_tuned_) { |
Collaborator
There was a problem hiding this comment.
I think this value can be changed to be set as dynamically configurable in the configuration file
byseea11
pushed a commit
to byseea11/pikiwidb
that referenced
this pull request
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s upper bound. fix #3084
Summary by CodeRabbit