fix: After connecting to Pika via telnet and pressing Enter, it causes Pika core dump#3099
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: wuxianrong <wuxianrong@360.cn>
使用 telnet 连上 Pika 之后直接回车,会让 Pika 接受到一个 "\r\n" 的包,最终会导致 Pika Core 在了 std::string opt = argvs[0][0]; 这里,PR 增加了对空命令包判断,测试后发现没有之前 core 的问题
#3095