Fix potential XSS in Markdown rendering via Event Delegation#332
Closed
RinZ27 wants to merge 1 commit intoOpenBMB:mainfrom
Closed
Fix potential XSS in Markdown rendering via Event Delegation#332RinZ27 wants to merge 1 commit intoOpenBMB:mainfrom
RinZ27 wants to merge 1 commit intoOpenBMB:mainfrom
Conversation
RinZ27
force-pushed
the
fix-xss-dompurify-event-delegation
branch
3 times, most recently
from
25173b2 to
f9e6be3
Compare
RinZ27
force-pushed
the
fix-xss-dompurify-event-delegation
branch
from
f9e6be3 to
392121a
Compare
Collaborator
|
@RinZ27 Thanks for the PR~ We're currently refactoring the frontend, and the relevant UI code is being significantly reworked. Because of that, we can't merge this PR in its current form, as it would likely conflict with the new frontend structure. We appreciate the security fix and may revisit it after the refactor is stabilized. |
Author
|
@xhd0728 Understood. I'll keep an eye on the frontend refactor and re-evaluate the fix once things stabilize. Thanks for the heads up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the Markdown rendering in ui/frontend/main.js to close a potential XSS vector. The previous implementation allowed inline JavaScript via onclick attributes, which could be exploited through prompt injection.
I've moved the interaction logic to a global click event listener using event delegation. This allowed me to strip onclick from the DOMPurify allow-list and replace inline handlers with data attributes (data-code-id, data-ref-id). I've verified that 'Copy Code' and 'Citation' links still work exactly as expected.