feat(v4.0.0): migrate 50 more endpoints to Http4s400 (176/258, 68%)

Batches 9–12 in Http4s400.scala add 42 real `lazy val NAME: HttpRoutes[IO]`
handlers ported from Lift, plus 8 ResourceDoc aliases reusing the existing
`createTransactionRequest` handler for the transaction-request-type variants
(ACCOUNT, ACCOUNT_OTP, SEPA, COUNTERPARTY, REFUND, FREE_FORM, SIMPLE,
AGENT_CASH_WITHDRAWAL — already covered by `literalAllCapsSegments` in
Http4sSupport).

Post-batch fixes:
- deleteExplicitCounterparty: COUNTERPARTY_ID → COUNTERPARTY_ID_PARAM in
  ResourceDoc URL so middleware skips the counterparty lookup (400 vs 404
  for missing IDs)
- updateBankAttribute: add canUpdateBankAttribute role to ResourceDoc so
  middleware returns 403 (test expectation) instead of handler's 400
- getFastFirehoseAccountsAtOneBank: read pagination from URL query string
  via extractHttpParamsFromUrl, not from headers — matching Lift v4

ErrorResponseConverter + ErrorMessages.getCodeByOBPPrefix:
- For any thrown Exception with an OBP-XXXXX prefixed message and the
  default failCode=400, look up the canonical status code in
  ErrorMessages.errorToCode by OBP prefix. Reproduces Lift's
  errorJsonResponse behaviour (403 for UserNoPermissionAccessView,
  UserHasMissingRoles, etc.; 401 for AuthenticatedUserIsRequired). Caller
  who set failCode explicitly is honored.

Skipped 43 endpoints (dynamic/reflection: 31; complex authn: 12) remain
on the Lift bridge — they'll be addressed in a follow-up batch.

v4 test suite: 491 passed, 1 pre-existing failure (ApiCollectionEndpointTest
BGv1.3-getConsentStatus, fails on prior commit too).

Author: constantine2nd

obp-api/src/main/scala/code/api/util/ErrorMessages.scala

@@ -1029,6 +1029,19 @@ object ErrorMessages {
    */
   def getCode(errorMsg: String): Int = errorToCode.get(errorMsg).getOrElse(400)
 
+  /**
+   * Resolve HTTP status code for an OBP-prefixed error message that may have a
+   * runtime suffix appended (e.g. "OBP-20020: User does not have access to the view.
+   * Current ViewId is owner"). Extracts the OBP-XXXXX prefix and returns the
+   * canonical status code from errorToCode, or 400 if not found.
+   */
+  def getCodeByOBPPrefix(errorMsg: String): Int = {
+    val prefixOpt = "OBP-\\d{5}".r.findFirstIn(errorMsg)
+    prefixOpt.flatMap { prefix =>
+      errorToCode.find { case (key, _) => key.startsWith(prefix + ":") }.map(_._2)
+    }.getOrElse(400)
+  }
+
   /****** special error message, start with $, mark as do validation according ResourceDoc errorResponseBodies *****/
   /**
    * validate method: APIUtil.authorizedAccess

obp-api/src/main/scala/code/api/util/http4s/ErrorResponseConverter.scala

@@ -85,13 +85,24 @@ object ErrorResponseConverter {
     }
   }
 
+  /**
+   * Translate a 400 default with an OBP-prefixed message to the canonical status
+   * Lift assigns (403 for role/view-access codes, 401 for auth codes, etc.) via
+   * ErrorMessages.getCodeByOBPPrefix. Leaves non-400 failCodes (caller set
+   * status explicitly) untouched.
+   */
+  private def resolveStatusCode(failCode: Int, failMsg: String): Int =
+    if (failCode == 400) code.api.util.ErrorMessages.getCodeByOBPPrefix(failMsg)
+    else failCode
+
   /**
    * Convert APIFailureNewStyle to http4s Response.
    * Uses failCode as HTTP status and failMsg as error message.
    */
   def apiFailureToResponse(failure: APIFailureNewStyle, callContext: CallContext): IO[Response[IO]] = {
-    val errorJson = OBPErrorResponse(failure.failCode, failure.failMsg)
-    val status = org.http4s.Status.fromInt(failure.failCode).getOrElse(org.http4s.Status.BadRequest)
+    val resolvedCode = resolveStatusCode(failure.failCode, failure.failMsg)
+    val errorJson = OBPErrorResponse(resolvedCode, failure.failMsg)
+    val status = org.http4s.Status.fromInt(resolvedCode).getOrElse(org.http4s.Status.BadRequest)
     IO.pure(
       Response[IO](status)
         .withEntity(toJsonString(errorJson))