Address review: rename setting and flip default for eraser workaround

Rename boardAutoSwitchToEraser -> boardIgnoreBrokenEraserDetection to
make it clear this is a workaround for broken eraser detection, not a
general preference. Default is now false (opt-in). Update the checkbox
label to "Ignore broken eraser detection for tablets".

Signed-off-by: ElmotiemSofian <sofianelmotiem@gmail.com>

Author: SofianElmotiem

resources/forms/preferences.ui

@@ -951,7 +951,7 @@
        <item row="1" column="0" colspan="2">
         <widget class="QCheckBox" name="autoSwitchToEraserCheckBox">
          <property name="text">
-          <string>Automatically switch to eraser when tablet eraser is detected</string>
+          <string>Ignore broken eraser detection for tablets</string>
          </property>
         </widget>
        </item>

src/board/UBBoardView.cpp

@@ -350,13 +350,13 @@ void UBBoardView::tabletEvent (QTabletEvent * event)
     UBStylusTool::Enum currentTool = (UBStylusTool::Enum)dc->stylusTool ();
 
     if (event->type () == QEvent::TabletPress || event->type () == QEvent::TabletEnterProximity) {
-        const bool autoSwitch = UBSettings::settings()->boardAutoSwitchToEraser->get().toBool();
+        const bool ignoreBrokenEraser = UBSettings::settings()->boardIgnoreBrokenEraserDetection->get().toBool();
 #if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0))
         if (event->pointerType () == QPointingDevice::PointerType::Eraser) {
 #else
         if (event->pointerType () == QTabletEvent::Eraser) {
 #endif
-            if (autoSwitch) {
+            if (!ignoreBrokenEraser) {
                 dc->setStylusTool (UBStylusTool::Eraser);
                 mUsingTabletEraser = true;
             }

src/core/UBPreferencesController.cpp

@@ -271,7 +271,7 @@ void UBPreferencesController::wire()
     connect(mPenProperties->circleCheckBox, SIGNAL(clicked(bool)), settings, SLOT(setPenPreviewCircle(bool)));
     connect(mPenProperties->circleSpinBox, SIGNAL(valueChanged(int)), this, SLOT(penPreviewFromSizeChanged(int)));
 
-    connect(mPreferencesUI->autoSwitchToEraserCheckBox, SIGNAL(clicked(bool)), settings->boardAutoSwitchToEraser, SLOT(setBool(bool)));
+    connect(mPreferencesUI->autoSwitchToEraserCheckBox, SIGNAL(clicked(bool)), settings->boardIgnoreBrokenEraserDetection, SLOT(setBool(bool)));
 
     // marker
     QList<QColor> markerLightBackgroundColors = settings->boardMarkerLightBackgroundColors->colors();
@@ -344,7 +344,7 @@ void UBPreferencesController::init()
     mPenProperties->pressureSensitiveCheckBox->setChecked(settings->boardPenPressureSensitive->get().toBool());
     mPenProperties->circleCheckBox->setChecked(settings->showPenPreviewCircle->get().toBool());
     mPenProperties->circleSpinBox->setValue(settings->penPreviewFromSize->get().toInt());
-    mPreferencesUI->autoSwitchToEraserCheckBox->setChecked(settings->boardAutoSwitchToEraser->get().toBool());
+    mPreferencesUI->autoSwitchToEraserCheckBox->setChecked(settings->boardIgnoreBrokenEraserDetection->get().toBool());
 
     // marker tab
     mMarkerProperties->fineSlider->setValue(settings->boardMarkerFineWidth->get().toDouble() * sSliderRatio);

src/core/UBSettings.cpp

@@ -285,7 +285,7 @@ void UBSettings::init()
     boardMarkerPressureSensitive = new UBSetting(this, "Board", "MarkerPressureSensitive", false);
 
     boardUseHighResTabletEvent = new UBSetting(this, "Board", "UseHighResTabletEvent", true);
-    boardAutoSwitchToEraser = new UBSetting(this, "Board", "AutoSwitchToEraser", true);
+    boardIgnoreBrokenEraserDetection = new UBSetting(this, "Board", "IgnoreBrokenEraserDetection", false);
 
     boardInterpolatePenStrokes = new UBSetting(this, "Board", "InterpolatePenStrokes", true);
     boardSimplifyPenStrokes = new UBSetting(this, "Board", "SimplifyPenStrokes", true);

src/core/UBSettings.h

@@ -287,7 +287,7 @@ class UBSettings : public QObject
         UBSetting* boardMarkerPressureSensitive;
 
         UBSetting* boardUseHighResTabletEvent;
-        UBSetting* boardAutoSwitchToEraser;
+        UBSetting* boardIgnoreBrokenEraserDetection;
 
         UBSetting* boardInterpolatePenStrokes;
         UBSetting* boardSimplifyPenStrokes;