refactor: Improve imports and fix SFINAE issues

Some forward declarations cause SFINAE issues, because the
definition is needed to choose the correct template.
This affects the classes UBGraphicsMediaItem, UBGraphicsTextItem,
UBBackgroundRuling, UBToolWidget, and WebView.

To eliminate these forward declarations, the imports need to be
restructured. The easiest case is replacing the forward declaration
with the include of the definition.

This doesn't quite work for UBGraphicsMediaItem as it causes an
include cycle:
src/domain/UBGraphicsMediaItem.h includes src/domain/UBItem.h which
includes src/domain/UBGraphicsItemDelegate.h which includes
src/domain/UBGraphicsMediaItem.h
The solution provided here is to turn the UBGraphicsMediaItem class
into a forward declaration in src/domain/UBGraphicsItemDelegate.h

In the course of this work, UBGraphicsItem has been split from
UBItem into its own file; this surfaced a lot of transitive includes
that weren't properly declared.

Author: Vekhir

src/adaptors/UBExportDocumentSetAdaptor.cpp

@@ -25,21 +25,9 @@
  */
 
 
-#include "UBExportDocumentSetAdaptor.h"
-#include "UBExportDocument.h"
-
-#include "adaptors/UBPageMapper.h"
-
-#include "frameworks/UBPlatformUtils.h"
-
-#include "core/UBDocumentManager.h"
-#include "core/UBApplication.h"
 
-#include "document/UBDocumentProxy.h"
-#include "document/UBDocumentController.h"
-#include "document/UBDocumentToc.h"
 
-#include "core/UBPersistenceManager.h"
+#include "UBExportDocumentSetAdaptor.h"
 
 #ifdef Q_OS_OSX
     #include <quazip.h>
@@ -49,7 +37,21 @@
     #include "quazipfile.h"
 #endif
 
+#include "adaptors/UBPageMapper.h"
+
 #include "core/memcheck.h"
+#include "core/UBApplication.h"
+#include "core/UBDocumentManager.h"
+#include "core/UBPersistenceManager.h"
+#include "core/UBSettings.h"
+
+#include "document/UBDocumentProxy.h"
+#include "document/UBDocumentController.h"
+#include "document/UBDocumentToc.h"
+
+#include "frameworks/UBPlatformUtils.h"
+
+#include "UBExportDocument.h"
 
 UBExportDocumentSetAdaptor::UBExportDocumentSetAdaptor(QObject *parent)
     : UBExportAdaptor(parent)

src/adaptors/UBSvgSubsetAdaptor.cpp

@@ -49,6 +49,7 @@
 #include "domain/UBGraphicsStrokesGroup.h"
 #include "domain/UBGraphicsGroupContainerItem.h"
 #include "domain/UBGraphicsGroupContainerItemDelegate.h"
+#include "domain/UBGraphicsItem.h"
 #include "domain/UBItem.h"
 
 #include "gui/UBBackgroundRuling.h"

src/adaptors/UBSvgSubsetAdaptor.h

@@ -36,18 +36,19 @@
 
 #include <optional>
 
+#include "domain/UBGraphicsMediaItem.h"
+#include "domain/UBGraphicsTextItem.h"
+
 #include "frameworks/UBGeometryUtils.h"
 
 class UBGraphicsSvgItem;
 class UBGraphicsPolygonItem;
 class UBGraphicsPixmapItem;
 class UBGraphicsPDFItem;
 class UBGraphicsWidgetItem;
-class UBGraphicsMediaItem;
 class UBGraphicsVideoItem;
 class UBGraphicsAudioItem;
 class UBGraphicsW3CWidgetItem;
-class UBGraphicsTextItem;
 class UBGraphicsCurtainItem;
 class UBGraphicsRuler;
 class UBGraphicsAxes;

src/adaptors/UBWidgetUpgradeAdaptor.cpp

@@ -25,16 +25,20 @@
  */
 
 
-#include "UBWidgetUpgradeAdaptor.h"
 
-#include "core/UBPersistenceManager.h"
-#include "document/UBDocumentProxy.h"
-#include "frameworks/UBPlatformUtils.h"
+
+#include "UBWidgetUpgradeAdaptor.h"
 
 #include <QCryptographicHash>
 #include <QDomDocument>
 
 #include "core/memcheck.h"
+#include "core/UBPersistenceManager.h"
+#include "core/UBSettings.h"
+
+#include "document/UBDocumentProxy.h"
+
+#include "frameworks/UBPlatformUtils.h"
 
 UBWidgetUpgradeAdaptor::UBWidgetUpgradeAdaptor()
 {

src/board/UBBoardController.cpp

@@ -59,6 +59,7 @@
 #include "document/UBDocumentProxy.h"
 
 #include "domain/UBGraphicsGroupContainerItem.h"
+#include "domain/UBGraphicsItem.h"
 #include "domain/UBGraphicsItemUndoCommand.h"
 #include "domain/UBGraphicsMediaItem.h"
 #include "domain/UBGraphicsPDFItem.h"

src/board/UBBoardController.h

@@ -40,12 +40,14 @@
 #include "core/UB.h"
 #include "core/UBApplicationController.h"
 #include "document/UBDocumentContainer.h"
+#include "domain/UBGraphicsMediaItem.h"
+#include "gui/UBBackgroundRuling.h"
+#include "gui/UBToolWidget.h"
 
 class UBMainWindow;
 class UBApplication;
 class UBBoardView;
 
-class UBBackgroundRuling;
 class UBBackgroundManager;
 class UBDocument;
 class UBDocumentController;
@@ -54,11 +56,9 @@ class UBGraphicsScene;
 class UBDocumentProxy;
 class UBEmbedController;
 class UBBlackoutWidget;
-class UBToolWidget;
 class UBVersion;
 class UBSoftwareUpdate;
 class UBSoftwareUpdateDialog;
-class UBGraphicsMediaItem;
 class UBGraphicsWidgetItem;
 class UBBoardPaletteManager;
 class UBItem;

src/board/UBBoardView.cpp

@@ -69,7 +69,7 @@
 #include "domain/UBGraphicsWidgetItem.h"
 #include "domain/UBGraphicsPDFItem.h"
 #include "domain/UBGraphicsPolygonItem.h"
-#include "domain/UBItem.h"
+#include "domain/UBGraphicsItem.h"
 #include "domain/UBGraphicsMediaItem.h"
 #include "domain/UBGraphicsSvgItem.h"
 #include "domain/UBGraphicsGroupContainerItem.h"

src/domain/CMakeLists.txt

@@ -5,6 +5,8 @@ target_sources(${PROJECT_NAME} PRIVATE
     UBGraphicsGroupContainerItem.h
     UBGraphicsGroupContainerItemDelegate.cpp
     UBGraphicsGroupContainerItemDelegate.h
+    UBGraphicsItem.cpp
+    UBGraphicsItem.h
     UBGraphicsItemDelegate.cpp
     UBGraphicsItemDelegate.h
     UBGraphicsItemGroupUndoCommand.cpp

src/domain/UBGraphicsGroupContainerItem.cpp

@@ -30,14 +30,17 @@
 #include "UBGraphicsGroupContainerItem.h"
 
 #include <QtGui>
+#include <QGraphicsItem>
+
+#include "core/memcheck.h"
+#include "core/UB.h"
 
-#include "UBGraphicsMediaItem.h"
-#include "UBGraphicsTextItem.h"
 #include "domain/UBGraphicsItemDelegate.h"
 #include "domain/UBGraphicsGroupContainerItemDelegate.h"
 #include "domain/UBGraphicsScene.h"
 
-#include "core/memcheck.h"
+#include "UBGraphicsMediaItem.h"
+#include "UBGraphicsTextItem.h"
 
 UBGraphicsGroupContainerItem::UBGraphicsGroupContainerItem(QGraphicsItem *parent)
     : QGraphicsItem(parent)

src/domain/UBGraphicsGroupContainerItem.h

@@ -32,6 +32,8 @@
 
 #include <QGraphicsItem>
 
+#include "core/UB.h"
+#include "domain/UBGraphicsItem.h"
 #include "domain/UBItem.h"
 #include "frameworks/UBCoreGraphicsScene.h"