clazy-incorrect-emit

- emitting inside constructor probably has no effect
- signal was not connected and therefore removed
- add missing emit keyword

Author: letsfindaway

src/core/UBPersistenceManager.cpp

@@ -103,8 +103,6 @@ UBPersistenceManager::UBPersistenceManager(QObject *pParent)
     mDocumentTreeStructureModel = new UBDocumentTreeModel(this);
     createDocumentProxiesStructure();
 
-    emit proxyListChanged();
-
     mThread = new QThread;
     mWorker = new UBPersistenceWorker();
     mWorker->moveToThread(mThread);
@@ -632,9 +630,7 @@ std::shared_ptr<UBDocumentProxy> UBPersistenceManager::createDocument(const QStr
     } else if (processInteractiveReplacementDialog(doc) == QDialog::Accepted) {
         addDoc = true;
     }
-    if (addDoc) {
-        emit proxyListChanged();
-    } else {
+    if (!addDoc) {
         deleteDocument(doc);
         doc = 0;
     }
@@ -710,7 +706,6 @@ std::shared_ptr<UBDocumentProxy> UBPersistenceManager::createDocumentFromDir(con
     }
     if (addDoc) {
         UBMetadataDcSubsetAdaptor::persist(doc);
-        emit proxyListChanged();
         emit documentCreated(doc);
     } else {
         deleteDocument(doc);
@@ -762,8 +757,6 @@ std::shared_ptr<UBDocumentProxy> UBPersistenceManager::duplicateDocument(std::sh
 
     copy->setPageCount(sceneCount(copy));
 
-    emit proxyListChanged();
-
     emit documentCreated(copy);
 
     return copy;

src/core/UBPersistenceManager.h

@@ -158,9 +158,6 @@ class UBPersistenceManager : public QObject
         bool isSceneInCached(std::shared_ptr<UBDocumentProxy>proxy, int index) const;
 
     signals:
-
-        void proxyListChanged();
-
         void documentCreated(std::shared_ptr<UBDocumentProxy> pDocumentProxy);
         void documentMetadataChanged(std::shared_ptr<UBDocumentProxy> pDocumentProxy);
 

src/web/simplebrowser/WBHistory.cpp

@@ -274,7 +274,7 @@ void WBHistoryManager::clear()
     m_fullSave = true;
     m_saveTimer->changeOccurred();
     m_saveTimer->saveIfNeccessary();
-    historyReset();
+    emit historyReset();
 }
 
 void WBHistoryManager::loadSettings()