Skip to content

Add preference to disable automatic pen/eraser switching#1487

Open
SofianElmotiem wants to merge 2 commits into
OpenBoard-org:masterfrom
SofianElmotiem:feature/disable-auto-switch-to-eraser
Open

Add preference to disable automatic pen/eraser switching#1487
SofianElmotiem wants to merge 2 commits into
OpenBoard-org:masterfrom
SofianElmotiem:feature/disable-auto-switch-to-eraser

Conversation

@SofianElmotiem
Copy link
Copy Markdown

Fixes the annoyance where Openboard auto-switches to the eraser tool when a tablet device (like the Promethean Activ Panel) detects the eraser pointer type. There is now a checkbox in the Pen preferences tab to turn this off. Defaults to on so nothing changes for existing users.

Closes #1432

@Vekhir
Copy link
Copy Markdown
Contributor

Vekhir commented May 12, 2026

In my opinion, this seems to be a workaround for broken pens. As such, I'd rather the option make that clear with a text like "Ignore broken eraser detection for tablets", defaulting to off. Similar for the variables.

The proper solution would be a driver fix for the pen to disable this behaviour globally, since other software would behave just like OpenBoard. This is far outside the remit of OpenBoard.

@SofianElmotiem
Copy link
Copy Markdown
Author

Thanks for the review! Makes sens
I'll update the label to make it clear this is a workaround, flip the default to off, and rename the variables accordingly.

@Vekhir
Copy link
Copy Markdown
Contributor

Vekhir commented May 13, 2026

Looks fine now. The commit messages are very structured.

@SofianElmotiem
Copy link
Copy Markdown
Author

SofianElmotiem commented May 13, 2026

Your suggestion made the intent much clearer that i need to rethink about it , and let me know if there is anything else to adjust before this can be merged.

@Vekhir
Copy link
Copy Markdown
Contributor

Vekhir commented May 13, 2026

Some people like to add a Signed-off-by: to signify that they as a human are the original authors of the code. It's part of the Developer Certificate of Origin.

What do you think?

@SofianElmotiem
Copy link
Copy Markdown
Author

Honsetly did not know it before but for sure happy to add it

@SofianElmotiem SofianElmotiem force-pushed the feature/disable-auto-switch-to-eraser branch from 711621f to 142b2b4 Compare May 13, 2026 20:15
@Vekhir
Copy link
Copy Markdown
Contributor

Vekhir commented May 14, 2026

I saw that your account is quite new, so I thought to mention it.
From this point, I don't have anything else to add. Let's see what the others might say.

@SofianElmotiem
Copy link
Copy Markdown
Author

thats right it took me some time considering contributing to opensource but i did it in the end. so i am happy to share and learn from the community.

@Vekhir
Copy link
Copy Markdown
Contributor

Vekhir commented May 14, 2026

Welcome to opensource!

Fixes the annoyance where Openboard auto-switches to the eraser tool
when a tablet device (like the Promethean Activ Panel) detects the
eraser pointer type. There is now a checkbox in the Pen preferences tab
to turn this off. Defaults to on so nothing changes for existing users.

Closes OpenBoard-org#1432
Rename boardAutoSwitchToEraser -> boardIgnoreBrokenEraserDetection to
make it clear this is a workaround for broken eraser detection, not a
general preference. Default is now false (opt-in). Update the checkbox
label to "Ignore broken eraser detection for tablets".

Signed-off-by: SofianElmotiem <sofianelmotiem@gmail.com>
@SofianElmotiem SofianElmotiem force-pushed the feature/disable-auto-switch-to-eraser branch from 142b2b4 to 6dd8554 Compare May 17, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Option to disable automatic switch between pen and eraser

2 participants