Support Poppler 26.4+ API change#1490
Open
Luigi-Arone wants to merge 1 commit into
Open
Conversation
In Poppler 26.4, getString() was changed to return a reference to GooString instead of a pointer. This break compilation against recent Poppler versions. Add a new branch to the version check to handle the new API while keeping compatibility with older versions.
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
May 13, 2026
OpenBoard is an open source cross-platform interactive whiteboard application designed primarily for use in schools. It was originally forked from Open-Sankore, which was itself based on Uniboard. It supports digital pens, virtual keyboards, PDF import, web browsing, video playback, and screen annotations. WWW: https://www.openboard.org/ https://github.com/OpenBoard-org/OpenBoard/ Patches reported to upstream: OpenBoard-org/OpenBoard#1489 OpenBoard-org/OpenBoard#1490 PR: 295104 Sponsored by: UNIS Labs
Contributor
|
This code is unused, so the PR #1474 removes it and also solves the issue. Nice work on the FreeBSD port |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Poppler 26.4,
getString()was changed to return a reference toGooStringinstead of a pointer, which breaks compilation againstrecent Poppler versions.
This PR adds a new branch to the version check in
src/pdf/XPDFRenderer.cppto handle the new API while keepingcompatibility with older versions.
Testing
Tested on FreeBSD 15.0-CURRENT amd64.
Context
Discovered while packaging OpenBoard for the FreeBSD ports tree
(Bug 295104).