Fix/dice typo#1491
Open
SofianElmotiem wants to merge 1 commit into
Open
Conversation
Contributor
|
The first two commits are unrelated to this PR. It's good to remove them, so each PR only contains the commits immediately relevant to it; this allows for flexibility regarding the merge order. Your commit descriptions are very close to Conventional Commits: https://www.conventionalcommits.org/en/v1.0.0/ |
SofianElmotiem
force-pushed
the
fix/dice-typo
branch
from
5ba3bbe to
42bf247
Compare
Author
|
Hey Vekhir ,I've rebased the branch so that it now contains only the one commit relevant to this fix. I have updated as well the commit message to follow Conventional Commits format as you suggested ( also learned something new there:) appreciate the pointer! |
Dice is already the correct plural form in English, dices is not standard. Updated all user-visible occurrences in the Dice widget help text and i18n properties file. (#dices) was left unchanged as it is internal code, not UI text. Fixes OpenBoard-org#1438 Signed-off-by: SofianElmotiem <sofianelmotiem@gmail.com>
SofianElmotiem
force-pushed
the
fix/dice-typo
branch
from
42bf247 to
9a815b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a grammar mistake in the Dice widget , "Dices" is not standard English, "Dice" is already the correct plural. Updated the help text and i18n file. Left the internal #dices element ID untouched since that's code, not UI text.
Fixes #1438