Use HTTPS for the clearadi submodule URL#5
Open
gregakespret wants to merge 1 commit into
Open
Conversation
The `clearadi` submodule is declared with `git@github.com:...` in
`.gitmodules`. SSH URLs require key-based auth, which fails for anyone
without an authorised SSH key and breaks `cargo build` of crates that
recurse into this repo via Cargo's git fetcher (cargo's URL parser
rejects the SSH form before any fetch is attempted, even with
`net.git-fetch-with-cli = true`).
The clearadi-stub repo is public, so switching to its HTTPS URL is
equivalent for anyone with read access and removes the build-time
friction. Anyone who has SSH credentials and prefers them can override
locally with:
git config url."git@github.com:".insteadOf "https://github.com/"
(or via `GIT_CONFIG_COUNT` env vars per invocation).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
gregakespret
added a commit
to gregakespret/rustpush
that referenced
this pull request
May 25, 2026
OpenBubbles/apple-private-apis/.gitmodules declares its `clearadi` sub-submodule with an SSH URL (`git@github.com:...`), which causes `cargo build` of any crate that recurses into this repo to fail because Cargo's URL parser rejects the SSH form before any fetch is delegated to system git — even with `net.git-fetch-with-cli = true`. gregakespret/apple-private-apis branch `fix-clearadi-submodule-url-to-https` fixes that one-line URL and is the PR proposed upstream at OpenBubbles/apple-private-apis#5. Until that lands, repoint our submodule URL at the fork (the SHA also moves forward by one commit that contains only the URL fix — no behavioural change). Revert this commit (re-point URL at OpenBubbles + bump submodule SHA back) once OpenBubbles/apple-private-apis#5 merges. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
clearadisubmodule is declared with an SSH URL(
git@github.com:OpenBubbles/clearadi-stub.git). That breakscargo buildfor any downstream crate that depends on this repotransitively, because Cargo's URL parser rejects the SSH form before
any fetch is attempted — and importantly, even setting
net.git-fetch-with-cli = truedoesn't help, because URL parsinghappens before the fetch is delegated to system git.
Concrete failure mode (reproduced against current
masterviathisiscam/rustpush→OpenBubbles/apple-private-apis):Since
clearadi-stubis a public read-only repository, an HTTPS URLis functionally equivalent for everyone and removes this friction
entirely. Anyone who prefers SSH for git operations can override
locally without affecting downstream crates:
How was this tested
Cloned this repo recursively via system git after applying the change
—
clearadi-stubchecks out cleanly without any authentication step.Then built a downstream crate (
thisiscam/export-findmy→thisiscam/rustpush) against this commit and confirmedcargo buildno longer errors on the submodule URL.