You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OpenSSL was causing a panic for me because the iv was missing in AES operations. This fixes that by manually setting the IV to the default constant value.
Not sure why that results in an error now but I guess something changed on OpenSSL's side.
+1 — reproduced today on macOS 26 with the Homebrew cargo 1.95.0 toolchain and openssl = 0.10.80. The exact panic point is Crypter::new(...) at src/util.rs:1591 (and the decrypt(...) call at :1621):
thread 'main' panicked at openssl/symm.rs:623:
an IV is required for this cipher
Easy public reproduction: any tool that drives rustpush through a PCS-encrypted CloudKit zone hits it on the first pcs_keys_for_record(...) call (the RFC 6637 unwrap path inside Crypter::new). The chain I hit it on:
thisiscam/export-findmy → thisiscam/rustpush:findmy-export-support → this code → panics on the first BeaconStore record.
openssl 0.10.80 enforces an explicit IV for any cipher with non-zero iv_len() — passing None no longer falls through to the cipher's default. The fix here (the RFC 3394 §2.2.3.1 default constant 0xA6A6A6A6A6A6A6A6) is exactly what older openssl versions filled in internally, so the wire-level bytes are unchanged.
Any chance of a merge? Happy to test additional cases if useful. I had filed thisiscam/rustpush#1 before noticing this PR existed — closed it as a duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL was causing a panic for me because the iv was missing in AES operations. This fixes that by manually setting the IV to the default constant value.
Not sure why that results in an error now but I guess something changed on OpenSSL's side.