Various minor fixes

Author: OpenByteDev

Cargo.toml

@@ -33,6 +33,8 @@ uuid = { version = "1", features = ["v4"], default-features = false  }
 [features]
 default = ["runas"]
 runas = []
+doc-cfg = []
 
 [package.metadata.docs.rs]
 targets = ["x86_64-pc-windows-msvc"]
+all-features = true

src/hotkey.rs

@@ -31,8 +31,8 @@ pub enum HotkeyModifier {
 /// A set of [`HotkeyModifier`]s.
 pub type HotkeyModifiers = BitFlags<HotkeyModifier>;
 
-impl std::fmt::Display for HotkeyModifier {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+impl fmt::Display for HotkeyModifier {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(f, "{}", self.to_str())
     }
 }

src/icon.rs

@@ -1,5 +1,5 @@
 use std::{
-    fs,
+    fmt, fs,
     path::{Path, PathBuf},
 };
 
@@ -32,6 +32,12 @@ impl Icon {
     }
 }
 
+impl fmt::Display for Icon {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        write!(f, "{}@{}", self.path.display(), self.index)
+    }
+}
+
 impl From<PathBuf> for Icon {
     fn from(path: PathBuf) -> Self {
         Self::new(path)

src/lib.rs

@@ -1,4 +1,5 @@
 #![cfg(windows)]
+#![cfg_attr(feature = "doc-cfg", featre(doc_cfg))]
 #![warn(clippy::pedantic)]
 #![allow(
     clippy::missing_errors_doc,

src/shortcut.rs

@@ -15,13 +15,13 @@ use windows::{
     core::{Interface, PCWSTR},
 };
 
+#[cfg(feature = "runas")]
+use crate::runas;
 use crate::{
     Hotkey, Icon, Result, WindowState,
     buf_utils::{com_get_optional_path, com_get_optional_string},
     com::{self, ComResultExt},
 };
-#[cfg(feature = "runas")]
-use crate::runas;
 
 /// Represents a Windows shortcut (`.lnk`) file.
 ///

src/virtual_key.rs

@@ -10,7 +10,9 @@ const fn convert(key: VIRTUAL_KEY) -> u8 {
 }
 
 /// Represents a Win32 virtual-key code.
-/// Unknown values are captured in the `Other(u8)` variant.
+///
+/// Unknown values are captured in the [`Other`](VirtualKey::Other) variant.
+///
 /// See: <https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes>
 #[repr(u8)]
 #[derive(Debug, Clone, Copy, PartialEq, Eq, FromPrimitive, IntoPrimitive)]
@@ -197,7 +199,7 @@ impl VirtualKey {
     /// Return a short, human-friendly string for this key.
     ///
     /// For known keys this returns a borrowed `&'static str`. For unknown
-    /// values (`Other(u8)`) this returns an owned string like `VK_0xNN`.
+    /// values ([`Other`](VirtualKey::Other) this returns an owned string like `VK_0xNN`.
     #[must_use]
     pub fn to_str(&self) -> Cow<'static, str> {
         match self {
@@ -323,6 +325,30 @@ impl VirtualKey {
     pub fn from_raw(vk: u8) -> Self {
         Self::from_primitive(vk)
     }
+
+    #[must_use]
+    pub fn is_modifier(self) -> bool {
+        matches!(
+            self,
+            Self::Shift
+                | Self::Control
+                | Self::Menu
+                | Self::LShift
+                | Self::RShift
+                | Self::LControl
+                | Self::RControl
+                | Self::LMenu
+                | Self::RMenu
+        )
+    }
+
+    #[must_use]
+    pub fn is_mouse(self) -> bool {
+        matches!(
+            self,
+            Self::LButton | Self::RButton | Self::MButton | Self::XButton1 | Self::XButton2
+        )
+    }
 }
 
 impl fmt::Display for VirtualKey {