Skip to content

build(Makefile): add CONTAINER_PROG to specify container runtime#14

Open
synackd wants to merge 1 commit into
mainfrom
build/generalized-container
Open

build(Makefile): add CONTAINER_PROG to specify container runtime#14
synackd wants to merge 1 commit into
mainfrom
build/generalized-container

Conversation

@synackd
Copy link
Copy Markdown
Contributor

@synackd synackd commented May 13, 2026

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

Fixes #8.

Instead of assuming Docker for building containers, default to it unless CONTAINER_PROG specifies a different program (e.g. /usr/bin/podman).

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactor

For more info, see Contributing Guidelines.

Fixes #8.

Instead of assuming Docker for building containers, default to it unless
CONTAINER_PROG specifies a different program (e.g. /usr/bin/podman).

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
@synackd synackd requested a review from alexlovelltroy May 13, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building local docker containers with make docker-build is broken

1 participant