Skip to content

fix: add hostname resolution before BMC ID mapping#138

Open
davidallendj wants to merge 1 commit into
mainfrom
allend/fix-hostname-resolve
Open

fix: add hostname resolution before BMC ID mapping#138
davidallendj wants to merge 1 commit into
mainfrom
allend/fix-hostname-resolve

Conversation

@davidallendj

Copy link
Copy Markdown
Collaborator

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

This PR adds hostname resolution before BMC ID mappings occur in pkg/collect.go. This should allow collect to run using hostnames like https://x8000c0s1b1.

Fixes #137

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

Signed-off-by: David Allen <davidallendj@gmail.com>
@alexlovelltroy

Copy link
Copy Markdown
Member

Looks like the build is failing. Can you fix that so we can merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error "no mapping found from host selector 'x8000c0s1b1' to a BMC ID"

2 participants