Skip to content

Allow a custom HTTP client to be used with ServiceReservation #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidallendj merged 1 commit into from
Jan 20, 2026
+9 −0
Merged

Allow a custom HTTP client to be used with ServiceReservation #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/service-reservations/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ type ServiceReservation interface {

InitInstance(stateManagerServer string, reservationPath string, defaultTermMinutes int, logger *logrus.Logger, svcName string)

//Initialize with a custom http client (for example with OAuth2 transport)
InitWithHTTPClient(stateManagerServer string, reservationPath string, defaultTermMinutes int, logger *logrus.Logger, svcName string, httpClient *retryablehttp.Client)

//Try to aquire locks for a list of xnames, renewing them within 30 seconds of expiration.
Aquire(xnames []string) error

Expand Down Expand Up @@ -179,6 +182,12 @@ func (i *Production) InitInstance(stateManagerServer string, reservationPath str
i.Init(stateManagerServer, reservationPath, defaultTermMinutes, logger)
}

// Initialize with a custom http client (for example with OAuth2 transport)
func (i *Production) InitWithHTTPClient(stateManagerServer string, reservationPath string, defaultTermMinutes int, logger *logrus.Logger, svcName string, httpClient *retryablehttp.Client) {
i.InitInstance(stateManagerServer, reservationPath, defaultTermMinutes, logger, svcName)
i.httpClient = httpClient
}

// Lets make this really simple; Im going to wake up and see what expires in the next 30 seconds;
// then I will renew those things
func (i *Production) doRenewal() {
Expand Down
Loading