Draft
Configure HTTP client with system certificate pool for HTTPS requests#6
Conversation
Co-authored-by: wzshiming <6565744+wzshiming@users.noreply.github.com>
…edundant test Co-authored-by: wzshiming <6565744+wzshiming@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Support the system's trusted certificate chain for client
Configure HTTP client with system certificate pool for HTTPS requests
Oct 28, 2025
8df29d1 to
1d34e4f
Compare
dbb43f2 to
7fb2eb9
Compare
890c265 to
94c6dc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ChunkRunneruseshttp.DefaultClientfor downloading/uploading chunks from source and destination URLs. This PR explicitly configures the HTTP client to use the system's trusted certificate chain.Changes
pkg/runner/chunk_runner.go: AddednewHTTPClientWithSystemCerts()that cloneshttp.DefaultTransportand configures TLS withx509.SystemCertPool(). Falls back tohttp.DefaultClientif system cert pool unavailable.pkg/runner/chunk_runner_test.go: Added tests verifying TLS configuration uses system certificate pool.Implementation
Cloning
http.DefaultTransportpreserves connection pooling, timeouts, and proxy configuration while ensuring HTTPS requests validate certificates against the system trust store.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.