Skip to content

fix(web): keep sidebar nav icons embedded #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jialudev merged 2 commits into from
Jul 10, 2026
Merged

fix(web): keep sidebar nav icons embedded #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0b5be3
fix(web): keep sidebar nav icons embedded
Jul 10, 2026
6f1734a
fix(web): align sidebar navigation icons
jialudev Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions web/app/src/pages/WorkspacePage/components/WorkspaceSidebar/WorkspaceSidebar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,19 +323,11 @@
}

.primaryNavIcon svg {
display: block;
width: 20px;
height: 20px;
}

.primaryNavIconMask {
width: 20px;
height: 20px;
background: currentColor;
display: block;
-webkit-mask: var(--workspace-nav-icon-url) center / contain no-repeat;
mask: var(--workspace-nav-icon-url) center / contain no-repeat;
}

.primaryNavLabel {
min-width: 0;
flex: 1 1 auto;
Expand Down
51 changes: 28 additions & 23 deletions web/app/src/pages/WorkspacePage/components/WorkspaceSidebar/WorkspaceSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
import { useEffect, useMemo, useRef, useState } from "react";
import { PanelLeftOpen, Plus, Search } from "lucide-react";
import {
SidebarAlertTriangleIcon,
SidebarBoxIcon,
SidebarGrid07Icon,
SidebarLaptopIcon,
SidebarListUnordered4Icon,
SidebarMessageIcon,
SidebarPuzzlePiece02Icon,
SidebarRobotIcon,
SidebarTimer2Icon,
SidebarUserIcon,
SidebarUsersIcon,
} from "@/components/ui/Icons";
import { SidebarRailControlButton } from "./SidebarRailControlButton";
import { SidebarUserButton } from "./SidebarUserButton";
import { LogoMark, LogoWordmark } from "./WorkspaceSidebarBrand";
Expand All @@ -11,24 +24,22 @@ import { classNames } from "@/shared/lib/classNames";
import styles from "./WorkspaceSidebar.module.css";
import type { PrimaryNavigationItem, PrimaryNavigationSection } from "./WorkspacePrimaryNavigation";
import type { WorkspaceContextSectionId, WorkspaceSidebarProps } from "./types";
import type { CSSProperties } from "react";
import type { ComponentType } from "react";

type NavigationIconStyle = CSSProperties & {
"--workspace-nav-icon-url": string;
};
type SidebarNavigationIcon = ComponentType<{ size?: number | string }>;

const WORKSPACE_NAVIGATION_ICONS = {
agents: "icons/workspace-agents.svg",
computers: "icons/workspace-computers.svg",
humans: "icons/workspace-humans.svg",
messages: "icons/workspace-messages.svg",
models: "icons/workspace-models.svg",
notifications: "icons/workspace-notifications.svg",
scheduledTasks: "icons/workspace-scheduled-tasks.svg",
skills: "icons/workspace-skills.svg",
tasks: "icons/workspace-tasks.svg",
teams: "icons/workspace-teams.svg",
templates: "icons/workspace-templates.svg",
agents: SidebarRobotIcon,
computers: SidebarLaptopIcon,
humans: SidebarUserIcon,
messages: SidebarMessageIcon,
models: SidebarBoxIcon,
notifications: SidebarAlertTriangleIcon,
scheduledTasks: SidebarTimer2Icon,
skills: SidebarPuzzlePiece02Icon,
tasks: SidebarListUnordered4Icon,
teams: SidebarUsersIcon,
templates: SidebarGrid07Icon,
} as const;

export function WorkspaceSidebar({
Expand Down Expand Up @@ -535,14 +546,8 @@ export function WorkspaceSidebar({
);
}

function navigationIcon(path: string) {
return (
<span
className={styles.primaryNavIconMask}
style={{ "--workspace-nav-icon-url": `url("${path}")` } as NavigationIconStyle}
aria-hidden="true"
/>
);
function navigationIcon(Icon: SidebarNavigationIcon) {
return <Icon size={20} />;
}

function badgeCount(count: number | null | undefined) {
Expand Down
Loading