fix: skip metadata scan failures in push callback (#1247)

Co-authored-by: ganisback <370036720@qq.com>

Author: Rader

component/callback/git_callback.go

@@ -565,13 +565,13 @@ func (c *gitCallbackComponentImpl) updateModelMetadata(ctx context.Context, file
 	modelInfo, err := c.runtimeArchComponent.UpdateModelMetadata(ctx, repo)
 	if err != nil {
 		slog.Warn("fail to update model metadata", slog.Any("error", err), slog.Any("repo path", repo.Path))
-		return err
+		return nil
 	}
 	err = c.runtimeArchComponent.UpdateRuntimeFrameworkTag(ctx, modelInfo, repo)
 	if err != nil {
 		slog.Warn("fail to update runtime framework tag", slog.Any("error", err), slog.Any("repo path", repo.Path))
 	}
-	return err
+	return nil
 }
 
 // check if the repo is valid for runtime framework

component/callback/git_callback_test.go

@@ -2,6 +2,7 @@ package callback
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"testing"
 	"time"
@@ -211,6 +212,30 @@ func TestGitCallbackComponentImpl_UpdateRepoInfos(t *testing.T) {
 		err := gc.UpdateRepoInfos(context.Background(), req)
 		assert.NoError(t, err)
 	})
+
+	t.Run("should skip model metadata update failure", func(t *testing.T) {
+		gc := initializeTestGitCallbackComponent(context.Background(), t)
+		req := &types.GiteaCallbackPushReq{
+			Ref: "refs/heads/main",
+			Repository: types.GiteaCallbackPushReq_Repository{
+				FullName: "models_namespace/repo",
+			},
+			Commits: []types.GiteaCallbackPushReq_Commit{
+				{
+					Modified: []string{"config.json"},
+					Removed:  []string{"old_file.txt"},
+				},
+			},
+		}
+
+		gc.mocks.stores.RepoMock().EXPECT().FindByPath(ctx, types.ModelRepo, "namespace", "repo").Return(repo, nil)
+		gc.mocks.runtimeArchComponent.EXPECT().UpdateModelMetadata(ctx, repo).Return(nil, errors.New("unsupported model format unknown"))
+		gc.mocks.stores.RepoMock().EXPECT().FindByPath(ctx, types.ModelRepo, "namespace", "repo").Return(repo, nil)
+		gc.mocks.tagComponent.EXPECT().UpdateLibraryTags(ctx, types.ModelTagScope, "namespace", "repo", "old_file.txt", "").Return(nil)
+
+		err := gc.UpdateRepoInfos(context.Background(), req)
+		assert.NoError(t, err)
+	})
 }
 
 func TestGitCallbackComponentImpl_CalculateRepoSize(t *testing.T) {