Skip to content

Commit dd18ed6

Browse files
committed
Sycn recent changes (#826)
1 parent 9cb1497 commit dd18ed6

6 files changed

Lines changed: 41 additions & 7 deletions

File tree

api/workflow/activity/deploy_activity.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ func (a *DeployActivity) makeDeployEnv(ctx context.Context, hardware types.HardW
697697
}
698698
// handle boolean value
699699
if !strings.Contains(arg.Format, "%") {
700-
if value == "false" || value == "0" || value == "" {
700+
if value == "false" || value == "0" || value == "" || value == "disable" {
701701
continue
702702
}
703703
engineArgs.WriteString(" ")
@@ -769,6 +769,7 @@ func (a *DeployActivity) makeDeployEnv(ctx context.Context, hardware types.HardW
769769
envMap["HF_ENDPOINT"] = a.cfg.ModelDownloadEndpoint // "https://hub.opencsg-stg.com/"
770770
envMap["HF_HUB_OFFLINE"] = "1"
771771
envMap["HF_TASK"] = string(deployInfo.Task)
772+
envMap["VLLM_ENFORCE_EAGER"] = "1"
772773
}
773774

774775
if deployInfo.Type == types.FinetuneType {

api/workflow/worker_ce.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ package workflow
55
import (
66
"fmt"
77
"log/slog"
8+
"time"
89

910
"go.temporal.io/sdk/client"
1011
"go.temporal.io/sdk/log"
@@ -43,6 +44,9 @@ func StartWorkflow(cfg *config.Config, registerAsWorker bool) error {
4344
client, err := temporal.NewClient(client.Options{
4445
HostPort: cfg.WorkFLow.Endpoint,
4546
Logger: log.NewStructuredLogger(slog.Default()),
47+
ConnectionOptions: client.ConnectionOptions{
48+
GetSystemInfoTimeout: time.Duration(cfg.Temporal.GetSystemInfoTimeout) * time.Second,
49+
},
4650
}, "csghub-api")
4751
if err != nil {
4852
return fmt.Errorf("unable to create workflow client, error: %w", err)

builder/store/database/repository.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -673,17 +673,17 @@ func (s *repoStoreImpl) PublicToUser(ctx context.Context, repoType types.Reposit
673673
// join table by repo type to filter out deleted and half-created records
674674
switch repoType {
675675
case types.ModelRepo:
676-
q.Join("LEFT JOIN models ON models.repository_id = repository.id")
676+
q.Join("INNER JOIN models ON models.repository_id = repository.id")
677677
case types.DatasetRepo:
678-
q.Join("LEFT JOIN datasets ON datasets.repository_id = repository.id")
678+
q.Join("INNER JOIN datasets ON datasets.repository_id = repository.id")
679679
case types.CodeRepo:
680-
q.Join("LEFT JOIN codes ON codes.repository_id = repository.id")
680+
q.Join("INNER JOIN codes ON codes.repository_id = repository.id")
681681
case types.SpaceRepo:
682-
q.Join("LEFT JOIN spaces ON spaces.repository_id = repository.id")
682+
q.Join("INNER JOIN spaces ON spaces.repository_id = repository.id")
683683
case types.PromptRepo:
684-
q.Join("LEFT JOIN prompts ON prompts.repository_id = repository.id")
684+
q.Join("INNER JOIN prompts ON prompts.repository_id = repository.id")
685685
case types.MCPServerRepo:
686-
q.Join("LEFT JOIN mcp_servers ON mcp_servers.repository_id = repository.id")
686+
q.Join("INNER JOIN mcp_servers ON mcp_servers.repository_id = repository.id")
687687
}
688688

689689
if !isAdmin {

builder/store/database/repository_test.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -742,6 +742,16 @@ func TestRepoStore_PublicToUser(t *testing.T) {
742742
repo.UpdatedAt = time.Now()
743743
rn, err := store.CreateRepo(ctx, *repo)
744744
require.Nil(t, err)
745+
746+
// Create corresponding record in codes table for CodeRepo
747+
if repo.RepositoryType == types.CodeRepo {
748+
code := database.Code{
749+
RepositoryID: rn.ID,
750+
}
751+
_, err = db.Core.NewInsert().Model(&code).Exec(ctx)
752+
require.Nil(t, err)
753+
}
754+
745755
for _, tag := range repo.Tags {
746756
_, err = db.Core.NewInsert().Model(&tag).Exec(ctx, &tag)
747757
require.Nil(t, err)
@@ -1681,6 +1691,13 @@ func TestRepoStore_PublicToUserMirror(t *testing.T) {
16811691
require.Nil(t, err)
16821692
require.NotNil(t, repo)
16831693

1694+
// Create corresponding record in datasets table for DatasetRepo
1695+
dataset := database.Dataset{
1696+
RepositoryID: repo.ID,
1697+
}
1698+
_, err = db.Core.NewInsert().Model(&dataset).Exec(ctx)
1699+
require.Nil(t, err)
1700+
16841701
userName1 := "user_name_" + uuid.NewString()
16851702
repoName1 := "repo_name_" + uuid.NewString()
16861703
repo1, err := rs.CreateRepo(ctx, database.Repository{
@@ -1698,6 +1715,13 @@ func TestRepoStore_PublicToUserMirror(t *testing.T) {
16981715
require.Nil(t, err)
16991716
require.NotNil(t, repo1)
17001717

1718+
// Create corresponding record in datasets table for DatasetRepo
1719+
dataset1 := database.Dataset{
1720+
RepositoryID: repo1.ID,
1721+
}
1722+
_, err = db.Core.NewInsert().Model(&dataset1).Exec(ctx)
1723+
require.Nil(t, err)
1724+
17011725
mirrorStore := database.NewMirrorStoreWithDB(db)
17021726
mirror, err := mirrorStore.Create(ctx, &database.Mirror{
17031727
RepositoryID: repo1.ID,

cmd/csghub-server/cmd/dataviewer/launch.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55
"fmt"
66
"log/slog"
7+
"time"
78

89
"github.com/spf13/cobra"
910
"go.temporal.io/sdk/client"
@@ -47,6 +48,9 @@ var launchCmd = &cobra.Command{
4748
client, err := temporal.NewClient(client.Options{
4849
HostPort: cfg.WorkFLow.Endpoint,
4950
Logger: log.NewStructuredLogger(slog.Default()),
51+
ConnectionOptions: client.ConnectionOptions{
52+
GetSystemInfoTimeout: time.Duration(cfg.Temporal.GetSystemInfoTimeout) * time.Second,
53+
},
5054
}, "dataset-viewer")
5155
if err != nil {
5256
return fmt.Errorf("unable to create workflow client, error: %w", err)

common/config/config.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,7 @@ type Config struct {
512512
MaxConcurrentActivityExecutionSize int `env:"OPENCSG_TEMPORAL_MAX_CONCURRENT_ACTIVITY_EXECUTION_SIZE" default:"5"`
513513
MaxConcurrentLocalActivityExecutionSize int `env:"OPENCSG_TEMPORAL_MAX_CONCURRENT_LOCAL_ACTIVITY_EXECUTION_SIZE" default:"10"`
514514
MaxConcurrentWorkflowTaskExecutionSize int `env:"OPENCSG_TEMPORAL_MAX_CONCURRENT_WORKFLOW_TASK_EXECUTION_SIZE" default:"50"`
515+
GetSystemInfoTimeout int `env:"OPENCSG_TEMPORAL_GET_SYSTEM_INFO_TIMEOUT" default:"5"`
515516
}
516517

517518
APIRateLimiter struct {

0 commit comments

Comments
 (0)