fix: Misc fixes

Author: jabesq

shared/connector_linter/connector_linter/checks/vc3xx_code/_helpers.py

@@ -328,9 +328,7 @@ def find_field_defaults(
                     (
                         b.id
                         if isinstance(b, ast.Name)
-                        else b.attr
-                        if isinstance(b, ast.Attribute)
-                        else ""
+                        else b.attr if isinstance(b, ast.Attribute) else ""
                     )
                     for b in node.bases
                 ]

shared/connector_linter/connector_linter/checks/vc3xx_code/vc303_connector_type.py

@@ -158,6 +158,7 @@ def check_connector_type_hardcoded(ctx: ConnectorContext) -> list[CheckFinding]:
             CheckFinding(
                 message="Connector type hardcoded",
                 severity=Severity.WARNING,
+                suggestion="Consider using connectors-sdk base config classes to set the connector type via inheritance.",
                 file_path=file_path,
                 line=line,
             ),
@@ -170,6 +171,7 @@ def check_connector_type_hardcoded(ctx: ConnectorContext) -> list[CheckFinding]:
             CheckFinding(
                 message="Connector type hardcoded via Pydantic field",
                 severity=Severity.WARNING,
+                suggestion="Consider using connectors-sdk base config classes to set the connector type via inheritance.",
                 file_path=file_path,
                 line=line,
             ),

shared/connector_linter/connector_linter/checks/vc3xx_code/vc304_markings_checked.py

@@ -110,7 +110,7 @@ def check_markings_checked(ctx: ConnectorContext) -> list[CheckFinding]:
                     f"TLP extraction found in {file_path}:{line} "
                     "but check_max_tlp is not called"
                 ),
-                severity=Severity.WARNING,
+                severity=Severity.ERROR,
                 file_path=file_path,
                 line=line,
                 suggestion=(

shared/connector_linter/connector_linter/checks/vc3xx_code/vc306_log_level_default.py

@@ -21,7 +21,7 @@
 # Accepted values for the "error" log level.
 # Both "error" and "err" are valid — some logging frameworks use the short form.
 # ---------------------------------------------------------------------------
-_ERROR_VALUES = {"error", "err"}
+_ERROR_VALUES = "error"
 
 
 @CheckRegistry.register(
@@ -54,7 +54,7 @@ def check_log_level_default(ctx: ConnectorContext) -> list[CheckFinding]:
 
     if field_defaults:
         fd = field_defaults[0]
-        if fd.default_value and fd.default_value in _ERROR_VALUES:
+        if fd.default_value and fd.default_value == _ERROR_VALUES:
             return [
                 CheckFinding(
                     message=f"Log level defaults to '{fd.default_value}'",

shared/connector_linter/connector_linter/checks/vc3xx_code/vc313_pycti_generate_id.py

@@ -58,26 +58,7 @@
 _STIX_SRO_TYPES = frozenset({"Relationship", "Sighting"})
 
 # Combined set for checking
-_STIX_TYPES_NEEDING_ID = _STIX_SDO_TYPES | _STIX_SRO_TYPES
-
-# ---------------------------------------------------------------------------
-# Custom OpenCTI types — these are OpenCTI-specific extensions that also
-# need explicit id= for deterministic deduplication (not part of STIX 2.1
-# but follow the same pattern).
-# ---------------------------------------------------------------------------
-_CUSTOM_OCTI_TYPES = frozenset(
-    {
-        "CustomObjectCaseIncident",
-        "CustomObjectTask",
-        "CustomObjectChannel",
-        "CustomObservableCryptocurrencyWallet",
-        "CustomObservableHostname",
-        "CustomObservableMediaContent",
-        "CustomObservableUserAgent",
-    },
-)
-
-_ALL_TYPES_NEEDING_ID = _STIX_TYPES_NEEDING_ID | _CUSTOM_OCTI_TYPES
+_ALL_TYPES_NEEDING_ID = _STIX_SDO_TYPES | _STIX_SRO_TYPES
 
 
 def _get_stix2_imported_names(trees: dict[Path, ast.Module]) -> dict[Path, set[str]]:

shared/connector_linter/connector_linter/checks/vc3xx_code/vc314_auto_backpressure.py

@@ -111,7 +111,7 @@ def check_auto_backpressure(ctx: ConnectorContext) -> list[CheckFinding]:
         results.append(
             CheckFinding(
                 message="Uses while True loop instead of scheduler",
-                severity=Severity.WARNING,
+                severity=Severity.ERROR,
                 file_path=file_path,
                 line=line_no,
                 suggestion=(