refactor(connector): applying codestyle requirements

guzmud · Kakudou · commit be72c00a89ce · 2026-05-04T17:55:48.000+02:00
diff --git a/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/client_api.py b/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/client_api.py
@@ -5,7 +5,6 @@
 
 from google.auth.transport.requests import Request
 from google.oauth2.service_account import Credentials
-
 from google_secops_siem_incidents.models.rule_alert_response import RuleAlertResponse
 from google_secops_siem_incidents.settings import GoogleSecOpsConfig
 from google_secops_siem_incidents.utils.api_engine import ApiClient
diff --git a/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/connector.py b/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/connector.py
@@ -8,13 +8,12 @@
 from typing import Any
 
 import google.auth.exceptions
-from pycti import OpenCTIConnectorHelper
-
 from google_secops_siem_incidents.client_api import GoogleSecOpsApiClient
 from google_secops_siem_incidents.converter_to_stix import ConverterToStix
 from google_secops_siem_incidents.settings import ConnectorSettings
 from google_secops_siem_incidents.state_manager import GoogleSecOpsSIEMState
 from google_secops_siem_incidents.utils.timestamps import parse_ts as _parse_ts
+from pycti import OpenCTIConnectorHelper
 
 _LOG_PREFIX = "[CONNECTOR]"
 
diff --git a/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/converter_to_stix.py b/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/converter_to_stix.py
@@ -2,15 +2,14 @@
 
 from connectors_sdk.models import OrganizationAuthor, TLPMarking
 from connectors_sdk.models.enums import TLPLevel
-from pycti import OpenCTIConnectorHelper
-
 from google_secops_siem_incidents.mappers.file_mapper import map_files
 from google_secops_siem_incidents.mappers.hostname_mapper import map_hostname
 from google_secops_siem_incidents.mappers.incident_mapper import map_incident
 from google_secops_siem_incidents.mappers.ip_mapper import map_ip_addresses
 from google_secops_siem_incidents.mappers.relationship_mapper import map_relationships
 from google_secops_siem_incidents.mappers.user_account_mapper import map_user_accounts
 from google_secops_siem_incidents.models.rule_alert_response import Alert, RuleMetadata
+from pycti import OpenCTIConnectorHelper
 
 
 class ConverterToStix:
diff --git a/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/file_mapper.py b/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/file_mapper.py
@@ -4,7 +4,6 @@
 
 from connectors_sdk.models import File
 from connectors_sdk.models.enums import HashAlgorithm
-
 from google_secops_siem_incidents.mappers._utils import find_outcome
 from google_secops_siem_incidents.models.rule_alert_response import Outcome
 
diff --git a/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/hostname_mapper.py b/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/hostname_mapper.py
@@ -3,7 +3,6 @@
 from typing import Any
 
 from connectors_sdk.models import Hostname
-
 from google_secops_siem_incidents.mappers._utils import find_outcome
 from google_secops_siem_incidents.models.rule_alert_response import Outcome
 
diff --git a/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/incident_mapper.py b/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/incident_mapper.py
@@ -5,7 +5,6 @@
 
 from connectors_sdk.models import Incident
 from connectors_sdk.models.enums import IncidentType
-
 from google_secops_siem_incidents.mappers._utils import find_outcome
 from google_secops_siem_incidents.models.rule_alert_response import Alert, RuleMetadata
 
diff --git a/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/ip_mapper.py b/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/ip_mapper.py
@@ -3,7 +3,6 @@
 from typing import Any
 
 from connectors_sdk.models import IPV4Address, IPV6Address
-
 from google_secops_siem_incidents.mappers._utils import find_outcome
 from google_secops_siem_incidents.models.rule_alert_response import Outcome
 
diff --git a/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/user_account_mapper.py b/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/mappers/user_account_mapper.py
@@ -4,7 +4,6 @@
 
 from connectors_sdk.models import UserAccount
 from connectors_sdk.models.enums import AccountType
-
 from google_secops_siem_incidents.mappers._utils import find_outcome
 from google_secops_siem_incidents.models.rule_alert_response import Outcome
 
diff --git a/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/settings.py b/external-import/google-secops-siem-incidents/src/google_secops_siem_incidents/settings.py
@@ -25,7 +25,7 @@ class ExternalImportConnectorConfig(BaseExternalImportConnectorConfig):
     )
     scope: ListFromString = Field(
         ["Google SecOps SIEM Incidents"],
-        description="The scope of the connector, e.g. 'flashpoint'."
+        description="The scope of the connector, e.g. 'flashpoint'.",
     )
 
 
diff --git a/external-import/google-secops-siem-incidents/src/main.py b/external-import/google-secops-siem-incidents/src/main.py
@@ -2,9 +2,8 @@
 
 import traceback
 
-from pycti import OpenCTIConnectorHelper
-
 from google_secops_siem_incidents import ConnectorSettings, GoogleSecOpsConnector
+from pycti import OpenCTIConnectorHelper
 
 if __name__ == "__main__":
     try:
diff --git a/external-import/google-secops-siem-incidents/tests/test_connector_e2e.py b/external-import/google-secops-siem-incidents/tests/test_connector_e2e.py
@@ -6,6 +6,8 @@
 from unittest.mock import AsyncMock, MagicMock
 
 import pytest
+from google_secops_siem_incidents.connector import GoogleSecOpsConnector
+from google_secops_siem_incidents.models.rule_alert_response import RuleAlertResponse
 from pycti import OpenCTIConnectorHelper
 from tests_converter_stix.factories import (
     AlertFactory,
@@ -18,9 +20,6 @@
     make_ip_outcomes,
 )
 
-from google_secops_siem_incidents.connector import GoogleSecOpsConnector
-from google_secops_siem_incidents.models.rule_alert_response import RuleAlertResponse
-
 # =====================
 # Fixtures
 # =====================
diff --git a/external-import/google-secops-siem-incidents/tests/test_main.py b/external-import/google-secops-siem-incidents/tests/test_main.py
@@ -1,10 +1,9 @@
 """Smoke tests for top-level instantiation: ConnectorSettings → helper → connector."""
 
+from google_secops_siem_incidents import GoogleSecOpsConnector
 from pycti import OpenCTIConnectorHelper
 from test_helpers import make_stub_settings
 
-from google_secops_siem_incidents import GoogleSecOpsConnector
-
 
 # ---------------------------------------------------------------------------
 # BDD helpers
diff --git a/external-import/google-secops-siem-incidents/tests/tests_chronicle_client/factories.py b/external-import/google-secops-siem-incidents/tests/tests_chronicle_client/factories.py
@@ -2,8 +2,6 @@
 
 from unittest.mock import MagicMock, patch
 
-from polyfactory.factories.pydantic_factory import ModelFactory
-
 from google_secops_siem_incidents.client_api import GoogleSecOpsApiClient
 from google_secops_siem_incidents.models.rule_alert_response import (
     Alert,
@@ -17,6 +15,7 @@
     TimeWindow,
 )
 from google_secops_siem_incidents.settings import GoogleSecOpsConfig
+from polyfactory.factories.pydantic_factory import ModelFactory
 
 
 # ---------------------------------------------------------------------------
diff --git a/external-import/google-secops-siem-incidents/tests/tests_chronicle_client/test_alert_fetching.py b/external-import/google-secops-siem-incidents/tests/tests_chronicle_client/test_alert_fetching.py
@@ -7,7 +7,6 @@
 from unittest.mock import AsyncMock, patch
 
 import pytest
-
 from google_secops_siem_incidents.models.rule_alert_response import RuleAlertResponse
 from google_secops_siem_incidents.utils.api_engine.exceptions import (
     ApiCircuitOpenError,
@@ -16,6 +15,7 @@
     ApiRateLimitError,
     ApiTimeoutError,
 )
+
 from tests.tests_chronicle_client.factories import (
     AlertFactory,
     RuleAlertFactory,
diff --git a/external-import/google-secops-siem-incidents/tests/tests_chronicle_client/test_auth_init.py b/external-import/google-secops-siem-incidents/tests/tests_chronicle_client/test_auth_init.py
@@ -7,8 +7,8 @@
 from unittest.mock import MagicMock, patch
 
 import pytest
-
 from google_secops_siem_incidents.client_api import GoogleSecOpsApiClient
+
 from tests.tests_chronicle_client.factories import make_config
 
 
diff --git a/external-import/google-secops-siem-incidents/tests/tests_chronicle_client/test_response_models.py b/external-import/google-secops-siem-incidents/tests/tests_chronicle_client/test_response_models.py
@@ -9,6 +9,7 @@
 from google_secops_siem_incidents.models.rule_alert_response import (
     RuleAlertResponse,
 )
+
 from tests.tests_chronicle_client.factories import (
     AlertFactory,
     OutcomeFactory,
diff --git a/external-import/google-secops-siem-incidents/tests/tests_connector/test_connector.py b/external-import/google-secops-siem-incidents/tests/tests_connector/test_connector.py
@@ -3,11 +3,10 @@
 import sys
 from unittest.mock import AsyncMock, MagicMock, patch
 
+from google_secops_siem_incidents import GoogleSecOpsConnector
 from pycti import OpenCTIConnectorHelper
 from test_helpers import make_stub_settings
 
-from google_secops_siem_incidents import GoogleSecOpsConnector
-
 
 # ===========================================================================
 # BDD helpers
diff --git a/external-import/google-secops-siem-incidents/tests/tests_connector/test_state_manager.py b/external-import/google-secops-siem-incidents/tests/tests_connector/test_state_manager.py
@@ -2,9 +2,8 @@
 
 from unittest.mock import MagicMock
 
-from pycti import OpenCTIConnectorHelper
-
 from google_secops_siem_incidents.state_manager import GoogleSecOpsSIEMState
+from pycti import OpenCTIConnectorHelper
 
 # ===========================================================================
 # Helpers
diff --git a/external-import/google-secops-siem-incidents/tests/tests_converter_stix/factories.py b/external-import/google-secops-siem-incidents/tests/tests_converter_stix/factories.py
@@ -6,8 +6,6 @@
 
 from connectors_sdk.models import OrganizationAuthor, TLPMarking
 from connectors_sdk.models.enums import TLPLevel
-from polyfactory.factories.pydantic_factory import ModelFactory
-
 from google_secops_siem_incidents.models.rule_alert_response import (
     Alert,
     AlertField,
@@ -19,6 +17,7 @@
     StringSeq,
     TimeWindow,
 )
+from polyfactory.factories.pydantic_factory import ModelFactory
 
 
 # ---------------------------------------------------------------------------
diff --git a/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_file_mapper.py b/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_file_mapper.py
@@ -7,15 +7,15 @@
 
 from connectors_sdk.models import File
 from connectors_sdk.models.enums import HashAlgorithm
+
+# --- import under test (will cause ImportError → RED) ---
+from google_secops_siem_incidents.mappers.file_mapper import map_files  # noqa: E402
 from tests_converter_stix.factories import (
     make_author,
     make_file_outcomes,
     make_tlp_marking,
 )
 
-# --- import under test (will cause ImportError → RED) ---
-from google_secops_siem_incidents.mappers.file_mapper import map_files  # noqa: E402
-
 # Valid 64-char hex SHA-256 placeholder hashes for tests.
 _SHA256_A = "abc123" + "0" * 58
 _SHA256_B = "def456" + "0" * 58
diff --git a/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_hostname_mapper.py b/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_hostname_mapper.py
@@ -5,17 +5,16 @@
 BDD helpers: _given_ / _when_ / _then_ pattern (plain pytest, no pytest-bdd).
 """
 
+# --- import under test (will cause ImportError → RED) ---
+from google_secops_siem_incidents.mappers.hostname_mapper import (  # noqa: E402
+    map_hostname,
+)
 from tests_converter_stix.factories import (
     make_author,
     make_hostname_outcomes,
     make_tlp_marking,
 )
 
-# --- import under test (will cause ImportError → RED) ---
-from google_secops_siem_incidents.mappers.hostname_mapper import (  # noqa: E402
-    map_hostname,
-)
-
 
 # ---------------------------------------------------------------------------
 # Helpers
diff --git a/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_incident_mapper.py b/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_incident_mapper.py
@@ -9,6 +9,11 @@
 
 import pytest
 from connectors_sdk.models.enums import IncidentSeverity
+
+# --- import under test (will cause ImportError → RED) ---
+from google_secops_siem_incidents.mappers.incident_mapper import (  # noqa: E402
+    map_incident,
+)
 from tests_converter_stix.factories import (
     AlertFactory,
     AlertFieldFactory,
@@ -19,11 +24,6 @@
     make_tlp_marking,
 )
 
-# --- import under test (will cause ImportError → RED) ---
-from google_secops_siem_incidents.mappers.incident_mapper import (  # noqa: E402
-    map_incident,
-)
-
 
 # ---------------------------------------------------------------------------
 # Helpers
diff --git a/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_ip_mapper.py b/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_ip_mapper.py
@@ -6,16 +6,16 @@
 """
 
 from connectors_sdk.models import IPV4Address, IPV6Address
-from tests_converter_stix.factories import (
-    make_author,
-    make_ip_outcomes,
-    make_tlp_marking,
-)
 
 # --- import under test (will cause ImportError → RED) ---
 from google_secops_siem_incidents.mappers.ip_mapper import (  # noqa: E402
     map_ip_addresses,
 )
+from tests_converter_stix.factories import (
+    make_author,
+    make_ip_outcomes,
+    make_tlp_marking,
+)
 
 
 # ---------------------------------------------------------------------------
diff --git a/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_relationship_mapper.py b/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_relationship_mapper.py
@@ -11,12 +11,12 @@
 from connectors_sdk.models import Hostname, IPV4Address, Relationship, UserAccount
 from connectors_sdk.models.enums import RelationshipType
 from connectors_sdk.models.reference import Reference
-from tests_converter_stix.factories import make_author, make_tlp_marking
 
 # --- import under test (will cause ImportError → RED) ---
 from google_secops_siem_incidents.mappers.relationship_mapper import (  # noqa: E402
     map_relationships,
 )
+from tests_converter_stix.factories import make_author, make_tlp_marking
 
 
 # ---------------------------------------------------------------------------
diff --git a/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_user_account_mapper.py b/external-import/google-secops-siem-incidents/tests/tests_converter_stix/mappers/test_user_account_mapper.py
@@ -6,16 +6,16 @@
 """
 
 from connectors_sdk.models import UserAccount
-from tests_converter_stix.factories import (
-    make_author,
-    make_tlp_marking,
-    make_user_outcomes,
-)
 
 # --- import under test (will cause ImportError → RED) ---
 from google_secops_siem_incidents.mappers.user_account_mapper import (  # noqa: E402
     map_user_accounts,
 )
+from tests_converter_stix.factories import (
+    make_author,
+    make_tlp_marking,
+    make_user_outcomes,
+)
 
 
 # ---------------------------------------------------------------------------
diff --git a/external-import/google-secops-siem-incidents/tests/tests_converter_stix/test_converter.py b/external-import/google-secops-siem-incidents/tests/tests_converter_stix/test_converter.py
@@ -8,6 +8,8 @@
 
 from unittest.mock import MagicMock
 
+# --- import under test (will cause ImportError → RED) ---
+from google_secops_siem_incidents.converter_to_stix import ConverterToStix  # noqa: E402
 from tests_converter_stix.factories import (
     AlertFactory,
     AlertFieldFactory,
@@ -19,9 +21,6 @@
     make_user_outcomes,
 )
 
-# --- import under test (will cause ImportError → RED) ---
-from google_secops_siem_incidents.converter_to_stix import ConverterToStix  # noqa: E402
-
 
 # ---------------------------------------------------------------------------
 # Helpers
diff --git a/external-import/google-secops-siem-incidents/tests/tests_utils/test_api_engine/test_http_request_execution.py b/external-import/google-secops-siem-incidents/tests/tests_utils/test_api_engine/test_http_request_execution.py
@@ -10,7 +10,6 @@
 from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest
-
 from google_secops_siem_incidents.utils.api_engine.aio_http_client import AioHttpClient
 from google_secops_siem_incidents.utils.api_engine.exceptions import (
     ApiHttpError,
diff --git a/external-import/google-secops-siem-incidents/tests/tests_utils/test_api_engine/test_rate_limit_sliding_window.py b/external-import/google-secops-siem-incidents/tests/tests_utils/test_api_engine/test_rate_limit_sliding_window.py
@@ -9,7 +9,6 @@
 import time
 
 import pytest
-
 from google_secops_siem_incidents.utils.api_engine.rate_limiter import (
     RateLimiterRegistry,
     TokenBucketRateLimiter,
diff --git a/external-import/google-secops-siem-incidents/tests/tests_utils/test_api_engine/test_resilient_request_orchestration.py b/external-import/google-secops-siem-incidents/tests/tests_utils/test_api_engine/test_resilient_request_orchestration.py
@@ -9,7 +9,6 @@
 from unittest.mock import AsyncMock, MagicMock
 
 import pytest
-
 from google_secops_siem_incidents.utils.api_engine.aio_http_client import AioHttpClient
 from google_secops_siem_incidents.utils.api_engine.api_request_model import (
     ApiRequestModel,
diff --git a/external-import/google-secops-siem-incidents/tests/tests_utils/test_api_engine/test_token_bucket_rate_limiting.py b/external-import/google-secops-siem-incidents/tests/tests_utils/test_api_engine/test_token_bucket_rate_limiting.py
@@ -10,7 +10,6 @@
 import time
 
 import pytest
-
 from google_secops_siem_incidents.utils.api_engine.rate_limiter import (
     RateLimiterRegistry,
     TokenBucketRateLimiter,

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class ExternalImportConnectorConfig(BaseExternalImportConnectorConfig):`
`25`	`25`	`)`
`26`	`26`	`scope: ListFromString = Field(`
`27`	`27`	`["Google SecOps SIEM Incidents"],`
`28`		`- description="The scope of the connector, e.g. 'flashpoint'."`
	`28`	`+ description="The scope of the connector, e.g. 'flashpoint'.",`
`29`	`29`	`)`
`30`	`30`
`31`	`31`