Description
A couple of small items surfaced in internal-enrichment/censys-enrichment while the I was preparing follow-up work on this connector:
-
The logo field in __metadata__/connector_manifest.json currently references internal-enrichment/censys/__metadata__/logo.png. The connector's directory is censys-enrichment, so the catalog is looking for the logo under a path that isn't present. The image itself is already in place at internal-enrichment/censys-enrichment/__metadata__/logo.png ; the manifest just needs to point at it.
-
src/censys_enrichment/converter.py currently covers all three supported observable types in a single module. Reshaping it into a per-observable converters/ package along the same lines as other connectors would keep planned future enrichment work isolated to one file each and make incremental reviews easier. No behavior change intended - the existing tests continue to pass.
Happy to take feedback on either. A PR covering both is open at #6288.
Description
A couple of small items surfaced in
internal-enrichment/censys-enrichmentwhile the I was preparing follow-up work on this connector:The
logofield in__metadata__/connector_manifest.jsoncurrently referencesinternal-enrichment/censys/__metadata__/logo.png. The connector's directory iscensys-enrichment, so the catalog is looking for the logo under a path that isn't present. The image itself is already in place atinternal-enrichment/censys-enrichment/__metadata__/logo.png; the manifest just needs to point at it.src/censys_enrichment/converter.pycurrently covers all three supported observable types in a single module. Reshaping it into a per-observableconverters/package along the same lines as other connectors would keep planned future enrichment work isolated to one file each and make incremental reviews easier. No behavior change intended - the existing tests continue to pass.Happy to take feedback on either. A PR covering both is open at #6288.