[Censys enrichment] Split converter into package, fix manifest logo path#6288
Open
alimarhoon-censys wants to merge 7 commits into
Open
Conversation
Contributor License AgreementHey @alimarhoon-censys! Thank you for your contribution to Filigran! Before we can merge this pull request, we need you to sign our Contributor License Agreement (CLA). Why do we need a CLA?The CLA helps protect both you and Filigran. It ensures that:
How to signYou can sign the CLA using either of these methods:
Once signed, this comment will be automatically updated. ❌ CLA not signed yet This is an automated message from the Filigran CLA Bot. If you have questions, please contact the maintainers. |
…er isort grouping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
logofield in__metadata__/connector_manifest.jsonto point atinternal-enrichment/censys-enrichment/__metadata__/logo.png. The image was already in that location; the manifest was pointing one directory over.src/censys_enrichment/converter.pyinto aconverters/package (base.py,host.py,certificate.py,domain.py) plus a sharedbuilder.py. Same layout as some other connectors. No behavior change - the 23 existing tests all pass; the only test-file changes are import-path updates.EntityNotInScopeError,MaxTlpError,EntityTypeNotSupportedError,EntityHasNoUsableHashError) into a newerrors.py. They were previously co-located with the code that raised them.@field_validator("scope")insettings.pyso misconfiguredCONNECTOR_SCOPEvalues are surfaced at startup rather than at dispatch time. Mirrors the pattern used in other connectors.None-check inCensysStixBuilder.add_servicesfor the case whereadd_certificatereturnsNone, so the relationship creation is skipped cleanly.Related issues
Checklist