Skip to content

[Censys enrichment] Split converter into package, fix manifest logo path#6288

Open
alimarhoon-censys wants to merge 7 commits into
OpenCTI-Platform:masterfrom
alimarhoon-censys:feature/censys-cleanup-converter-split
Open

[Censys enrichment] Split converter into package, fix manifest logo path#6288
alimarhoon-censys wants to merge 7 commits into
OpenCTI-Platform:masterfrom
alimarhoon-censys:feature/censys-cleanup-converter-split

Conversation

@alimarhoon-censys
Copy link
Copy Markdown

@alimarhoon-censys alimarhoon-censys commented Apr 22, 2026

Proposed changes

  • Update the logo field in __metadata__/connector_manifest.json to point at internal-enrichment/censys-enrichment/__metadata__/logo.png. The image was already in that location; the manifest was pointing one directory over.
  • Reshape src/censys_enrichment/converter.py into a converters/ package (base.py, host.py, certificate.py, domain.py) plus a shared builder.py. Same layout as some other connectors. No behavior change - the 23 existing tests all pass; the only test-file changes are import-path updates.
  • Collect the typed exceptions (EntityNotInScopeError, MaxTlpError, EntityTypeNotSupportedError, EntityHasNoUsableHashError) into a new errors.py. They were previously co-located with the code that raised them.
  • Add a @field_validator("scope") in settings.py so misconfigured CONNECTOR_SCOPE values are surfaced at startup rather than at dispatch time. Mirrors the pattern used in other connectors.
  • Add a None-check in CensysStixBuilder.add_services for the case where add_certificate returns None, so the relationship creation is skipped cleanly.

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@filigran-cla-bot filigran-cla-bot Bot added the cla:pending CLA signature required label Apr 22, 2026
@filigran-cla-bot
Copy link
Copy Markdown

Contributor License Agreement

Hey @alimarhoon-censys!

Thank you for your contribution to Filigran! Before we can merge this pull request, we need you to sign our Contributor License Agreement (CLA).

Why do we need a CLA?

The CLA helps protect both you and Filigran. It ensures that:

  • You have the right to make this contribution
  • Filigran can use and distribute your contribution
  • Your contribution remains open source

How to sign

You can sign the CLA using either of these methods:

  1. 🔗 Sign directlyClick here to review and sign the CLA
  2. 📧 Via email — Check your inbox (and spam folder) for a signing invitation from Concord

Once signed, this comment will be automatically updated.


CLA not signed yet

This is an automated message from the Filigran CLA Bot. If you have questions, please contact the maintainers.

@romain-filigran romain-filigran added the partner used to identify PR from patner label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:pending CLA signature required partner used to identify PR from patner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Censys enrichment] Follow-up work: manifest logo path + converter restructure

3 participants