feat(tenable-vuln-management): migrate connector to the catalog (#5215)#6831
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6831 +/- ##
===========================================
+ Coverage 35.64% 80.02% +44.37%
===========================================
Files 2048 10 -2038
Lines 125310 956 -124354
===========================================
- Hits 44672 765 -43907
+ Misses 80638 191 -80447
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the tenable-vuln-management external-import connector to the connectors catalog model by adopting connectors-sdk settings/config patterns, updating runtime wiring (settings → helper → connector), and regenerating metadata (schema + config doc) to match the new environment variable namespace.
Changes:
- Introduce
ConnectorSettings(connectors-sdk) and refactor connector entrypoint to instantiateOpenCTIConnectorHelperfrom settings. - Migrate configuration namespace from legacy
TIO_*toTENABLE_VULN_MANAGEMENT_*, including deprecated aliases and updated docs/schema. - Add/adjust tests and lightweight formatting/cleanup across models and helpers.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| external-import/tenable-vuln-management/tests/tests_connector/test_settings.py | Adds settings validation tests for connectors-sdk-based ConnectorSettings. |
| external-import/tenable-vuln-management/tests/test_main.py | Adds smoke tests for settings/helper/connector instantiation with heavy pycti dependencies mocked. |
| external-import/tenable-vuln-management/tests/conftest.py | Adjusts test import path to load connector package from src/. |
| external-import/tenable-vuln-management/src/tenable_vuln_management/settings.py | Defines connectors-sdk settings models, defaults, and deprecated namespace mapping. |
| external-import/tenable-vuln-management/src/tenable_vuln_management/models/opencti.py | Formatting cleanups in STIX/OpenCTI model builders. |
| external-import/tenable-vuln-management/src/tenable_vuln_management/models/common.py | Formatting/readability changes in shared model utilities. |
| external-import/tenable-vuln-management/src/tenable_vuln_management/converter_to_stix.py | Updates Tenable URL construction to use the new config namespace. |
| external-import/tenable-vuln-management/src/tenable_vuln_management/connector.py | Refactors connector initialization to accept injected settings + helper; updates config field usage. |
| external-import/tenable-vuln-management/src/tenable_vuln_management/client_api.py | Switches Tenable client initialization and filters to the new config namespace. |
| external-import/tenable-vuln-management/src/tenable_vuln_management/init.py | Re-exports ConnectorSettings at package level. |
| external-import/tenable-vuln-management/src/main.py | Updates runtime entrypoint to instantiate settings + helper explicitly. |
| external-import/tenable-vuln-management/src/config.yml.sample | Updates sample YAML to the new namespace and field names. |
| external-import/tenable-vuln-management/requirements.txt | Adds dependency on connectors-sdk (git subdirectory install). |
| external-import/tenable-vuln-management/docker-compose.yml | Migrates env vars from TIO_* to TENABLE_VULN_MANAGEMENT_*. |
| external-import/tenable-vuln-management/metadata/connector_manifest.json | Enables manager support as part of catalog migration. |
| external-import/tenable-vuln-management/metadata/connector_config_schema.json | Adds generated JSON schema including deprecated variable aliases. |
| external-import/tenable-vuln-management/metadata/CONNECTOR_CONFIG_DOC.md | Adds generated configuration documentation table. |
throuxel
force-pushed
the
feat/5215-migrate-tenable
branch
from
June 29, 2026 15:16
b6c093b to
667b065
Compare
jabesq
requested changes
Jul 2, 2026
jabesq
left a comment
Member
There was a problem hiding this comment.
suggestion: Remove old config_variables.py
throuxel
force-pushed
the
feat/5215-migrate-tenable
branch
from
July 7, 2026 07:09
c4f66fe to
bd37708
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments