Skip to content

feat(tenable-vuln-management): migrate connector to the catalog (#5215)#6831

Merged
throuxel merged 3 commits into
masterfrom
feat/5215-migrate-tenable
Jul 8, 2026
Merged

feat(tenable-vuln-management): migrate connector to the catalog (#5215)#6831
throuxel merged 3 commits into
masterfrom
feat/5215-migrate-tenable

Conversation

@throuxel

@throuxel throuxel commented Jun 29, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Migrate connector

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Copilot AI review requested due to automatic review settings June 29, 2026 14:41
@throuxel throuxel self-assigned this Jun 29, 2026
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.69231% with 9 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...anagement/src/tenable_vuln_management/connector.py 41.66% 7 Missing ⚠️
...nagement/src/tenable_vuln_management/client_api.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6831       +/-   ##
===========================================
+ Coverage   35.64%   80.02%   +44.37%     
===========================================
  Files        2048       10     -2038     
  Lines      125310      956   -124354     
===========================================
- Hits        44672      765    -43907     
+ Misses      80638      191    -80447     
Files with missing lines Coverage Δ
...management/src/tenable_vuln_management/__init__.py 100.00% <100.00%> (ø)
...t/src/tenable_vuln_management/converter_to_stix.py 89.58% <100.00%> (ø)
...ement/src/tenable_vuln_management/models/common.py 92.72% <100.00%> (ø)
...ment/src/tenable_vuln_management/models/opencti.py 100.00% <100.00%> (ø)
...management/src/tenable_vuln_management/settings.py 100.00% <100.00%> (ø)
...nagement/src/tenable_vuln_management/client_api.py 55.40% <71.42%> (+8.10%) ⬆️
...anagement/src/tenable_vuln_management/connector.py 27.00% <41.66%> (+6.79%) ⬆️

... and 2039 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the tenable-vuln-management external-import connector to the connectors catalog model by adopting connectors-sdk settings/config patterns, updating runtime wiring (settings → helper → connector), and regenerating metadata (schema + config doc) to match the new environment variable namespace.

Changes:

  • Introduce ConnectorSettings (connectors-sdk) and refactor connector entrypoint to instantiate OpenCTIConnectorHelper from settings.
  • Migrate configuration namespace from legacy TIO_* to TENABLE_VULN_MANAGEMENT_*, including deprecated aliases and updated docs/schema.
  • Add/adjust tests and lightweight formatting/cleanup across models and helpers.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
external-import/tenable-vuln-management/tests/tests_connector/test_settings.py Adds settings validation tests for connectors-sdk-based ConnectorSettings.
external-import/tenable-vuln-management/tests/test_main.py Adds smoke tests for settings/helper/connector instantiation with heavy pycti dependencies mocked.
external-import/tenable-vuln-management/tests/conftest.py Adjusts test import path to load connector package from src/.
external-import/tenable-vuln-management/src/tenable_vuln_management/settings.py Defines connectors-sdk settings models, defaults, and deprecated namespace mapping.
external-import/tenable-vuln-management/src/tenable_vuln_management/models/opencti.py Formatting cleanups in STIX/OpenCTI model builders.
external-import/tenable-vuln-management/src/tenable_vuln_management/models/common.py Formatting/readability changes in shared model utilities.
external-import/tenable-vuln-management/src/tenable_vuln_management/converter_to_stix.py Updates Tenable URL construction to use the new config namespace.
external-import/tenable-vuln-management/src/tenable_vuln_management/connector.py Refactors connector initialization to accept injected settings + helper; updates config field usage.
external-import/tenable-vuln-management/src/tenable_vuln_management/client_api.py Switches Tenable client initialization and filters to the new config namespace.
external-import/tenable-vuln-management/src/tenable_vuln_management/init.py Re-exports ConnectorSettings at package level.
external-import/tenable-vuln-management/src/main.py Updates runtime entrypoint to instantiate settings + helper explicitly.
external-import/tenable-vuln-management/src/config.yml.sample Updates sample YAML to the new namespace and field names.
external-import/tenable-vuln-management/requirements.txt Adds dependency on connectors-sdk (git subdirectory install).
external-import/tenable-vuln-management/docker-compose.yml Migrates env vars from TIO_* to TENABLE_VULN_MANAGEMENT_*.
external-import/tenable-vuln-management/metadata/connector_manifest.json Enables manager support as part of catalog migration.
external-import/tenable-vuln-management/metadata/connector_config_schema.json Adds generated JSON schema including deprecated variable aliases.
external-import/tenable-vuln-management/metadata/CONNECTOR_CONFIG_DOC.md Adds generated configuration documentation table.

Comment thread external-import/tenable-vuln-management/src/tenable_vuln_management/connector.py Outdated
Comment thread external-import/tenable-vuln-management/src/tenable_vuln_management/__init__.py Outdated
Comment thread external-import/tenable-vuln-management/tests/conftest.py Outdated
Comment thread external-import/tenable-vuln-management/tests/tests_connector/test_settings.py Outdated
Comment thread external-import/tenable-vuln-management/tests/tests_connector/test_settings.py Outdated
@throuxel
throuxel force-pushed the feat/5215-migrate-tenable branch from b6c093b to 667b065 Compare June 29, 2026 15:16
@throuxel throuxel changed the title feat(tenable-vuln-management): migrate connector to the catalog feat(tenable-vuln-management): migrate connector to the catalog (#5215) Jun 29, 2026
@romain-filigran romain-filigran added the filigran team Item from the Filigran team. label Jun 29, 2026

@jabesq jabesq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Remove old config_variables.py

@throuxel
throuxel force-pushed the feat/5215-migrate-tenable branch from c4f66fe to bd37708 Compare July 7, 2026 07:09
@throuxel
throuxel requested a review from jabesq July 7, 2026 07:11

@jabesq jabesq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@throuxel
throuxel merged commit 90d2e6c into master Jul 8, 2026
21 of 22 checks passed
@throuxel
throuxel deleted the feat/5215-migrate-tenable branch July 8, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

5 participants