feat(reversinglabs-spectra-intel-submission): add to catalog (#6836)#6887
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6887 +/- ##
===========================================
- Coverage 34.89% 0.29% -34.61%
===========================================
Files 2010 1922 -88
Lines 123240 120648 -2592
===========================================
- Hits 43005 352 -42653
- Misses 80235 120296 +40061
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the ReversingLabs Spectra Intel Submission internal-enrichment connector to the OpenCTI connectors catalog, updating it to use connectors-sdk settings/contracts and adding a basic test suite to validate configuration and instantiation.
Changes:
- Refactors the connector entrypoint and configuration to
connectors-sdk(BaseConnectorSettings) and adds generated config schema/docs for catalog compatibility. - Moves the connector logic into
src/connector/connector.pyand updates container/compose paths and environment variable names accordingly. - Adds pytest coverage for settings validation and basic instantiation of the helper/connector.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| internal-enrichment/reversinglabs-spectra-intel-submission/src/main.py | New lightweight entrypoint wiring settings → helper → connector run(). |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/connector/connector.py | Connector logic moved/refactored into a class using ConnectorSettings + OpenCTIConnectorHelper. |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/connector/settings.py | Introduces connectors-sdk config models and connector-specific settings. |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/connector/init.py | Exposes connector classes for convenient imports. |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/init.py | Exposes ConnectorSettings at package level. |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/config.yml.sample | Adds catalog-style YAML sample config for the new settings layout. |
| internal-enrichment/reversinglabs-spectra-intel-submission/requirements.txt | Adds connectors-sdk and pydantic requirement for the new settings/models. |
| internal-enrichment/reversinglabs-spectra-intel-submission/Dockerfile | Updates workdir/path to the new connector directory name (keeps git install). |
| internal-enrichment/reversinglabs-spectra-intel-submission/entrypoint.sh | Updates working directory path before running main.py. |
| internal-enrichment/reversinglabs-spectra-intel-submission/docker-compose.yml | Updates env var names to match the new connectors-sdk config mapping. |
| internal-enrichment/reversinglabs-spectra-intel-submission/metadata/connector_manifest.json | Sets manager_supported: true for catalog/manager compatibility. |
| internal-enrichment/reversinglabs-spectra-intel-submission/metadata/connector_config_schema.json | Adds generated env-var JSON schema contract for catalog. |
| internal-enrichment/reversinglabs-spectra-intel-submission/metadata/CONNECTOR_CONFIG_DOC.md | Adds generated human-readable configuration documentation. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/conftest.py | Adds test-time sys.path setup to import connector code from src/. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/test_main.py | Adds instantiation tests for settings, helper, and connector. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/tests_connector/test_settings.py | Adds validation tests for settings parsing and error handling. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/tests_connector/init.py | Initializes the test package. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/test-requirements.txt | Adds pytest requirements for running the connector tests. |
Powlinett
left a comment
There was a problem hiding this comment.
LGTM 👍️
Maybe remove CONNECTOR_CONFIDENCE_LEVEL from docker-compose.yml before merging to avoid any confusion between doc/sample files and the connector's settings UI on OpenCTI.
Proposed changes
Related issues
Checklist
Further comments
Tested without creds