feat(reversinglabs-malware-presence): add to catalog (#6837)#6889
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (13.86%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6889 +/- ##
===========================================
+ Coverage 35.64% 62.62% +26.97%
===========================================
Files 2048 941 -1107
Lines 125310 54765 -70545
===========================================
- Hits 44672 34298 -10374
+ Misses 80638 20467 -60171
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
f753055 to
aa48841
Compare
…-supported migration
…ss for manager-supported mode
…Dockerfile (remove entrypoint.sh)
…n connector manifest
aa48841 to
1bf4334
Compare
There was a problem hiding this comment.
Pull request overview
This PR migrates the ReversingLabs Malware Presence internal-enrichment connector toward catalog/manager readiness by refactoring the runtime entrypoint, introducing connectors-sdk based settings/schema artifacts, and adding a basic pytest suite to validate settings and instantiation.
Changes:
- Refactor connector entrypoint to build
ConnectorSettings+OpenCTIConnectorHelper, instantiateReversingLabsConnector, and callrun(). - Add connectors-sdk based
ConnectorSettingsand generated config schema/docs for catalog usage. - Add initial unit tests (settings validation + main wiring) and test requirements.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| internal-enrichment/reversinglabs-malware-presence/src/main.py | New lightweight entrypoint that initializes settings/helper and runs the connector. |
| internal-enrichment/reversinglabs-malware-presence/src/connector/connector.py | Connector logic moved into a dedicated module and adapted to receive config/helper. |
| internal-enrichment/reversinglabs-malware-presence/src/connector/settings.py | Introduces connectors-sdk Pydantic settings models for OpenCTI/connector/ReversingLabs config. |
| internal-enrichment/reversinglabs-malware-presence/src/connector/init.py | Exposes ReversingLabsConnector and ConnectorSettings for simplified imports. |
| internal-enrichment/reversinglabs-malware-presence/src/init.py | Package export for settings. |
| internal-enrichment/reversinglabs-malware-presence/requirements.txt | Adds connectors-sdk + pydantic dependency for the new settings models. |
| internal-enrichment/reversinglabs-malware-presence/Dockerfile | Adjusts image layout/workdir and switches to CMD ["python3","main.py"]. |
| internal-enrichment/reversinglabs-malware-presence/entrypoint.sh | Removes legacy entrypoint script (now using Docker CMD directly). |
| internal-enrichment/reversinglabs-malware-presence/docker-compose.yml | Updates env var sample layout to reflect new defaults/optionality. |
| internal-enrichment/reversinglabs-malware-presence/config.yml.sample | Adds a connectors-sdk compatible YAML config sample. |
| internal-enrichment/reversinglabs-malware-presence/.env.sample | Adds a connectors-sdk compatible env var sample. |
| internal-enrichment/reversinglabs-malware-presence/metadata/connector_manifest.json | Marks connector as manager_supported: true for catalog/manager deployment. |
| internal-enrichment/reversinglabs-malware-presence/metadata/connector_config_schema.json | Adds generated JSON schema describing all supported env vars. |
| internal-enrichment/reversinglabs-malware-presence/metadata/CONNECTOR_CONFIG_DOC.md | Adds generated Markdown documentation for connector configuration. |
| internal-enrichment/reversinglabs-malware-presence/tests/conftest.py | Test bootstrap to import connector code from src/. |
| internal-enrichment/reversinglabs-malware-presence/tests/test_main.py | Tests wiring: settings instantiation, helper instantiation, connector instantiation. |
| internal-enrichment/reversinglabs-malware-presence/tests/tests_connector/test_settings.py | Tests settings validation for valid/invalid config dicts. |
| internal-enrichment/reversinglabs-malware-presence/tests/test-requirements.txt | Adds pytest + includes connector requirements for tests. |
| internal-enrichment/reversinglabs-malware-presence/tests/tests_connector/init.py | Test package marker. |
jabesq
left a comment
There was a problem hiding this comment.
Suggestion: Remove the lib package, which is no longer used
7b5647a to
205be9e
Compare
Proposed changes
Related issues
Checklist
Further comments
Tested without creds