Skip to content

feat(reversinglabs-malware-presence): add to catalog (#6837)#6889

Merged
throuxel merged 9 commits into
masterfrom
feat/reversinglabs-malware-presence-migration
Jul 8, 2026
Merged

feat(reversinglabs-malware-presence): add to catalog (#6837)#6889
throuxel merged 9 commits into
masterfrom
feat/reversinglabs-malware-presence-migration

Conversation

@throuxel

@throuxel throuxel commented Jul 1, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Add connector to catalog

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Tested without creds

@throuxel throuxel self-assigned this Jul 1, 2026
Copilot AI review requested due to automatic review settings July 1, 2026 14:54
@throuxel throuxel added the filigran team Item from the Filigran team. label Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 13.86861% with 354 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nglabs-malware-presence/src/connector/connector.py 9.69% 354 Missing ⚠️

❌ Your patch check has failed because the patch coverage (13.86%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6889       +/-   ##
===========================================
+ Coverage   35.64%   62.62%   +26.97%     
===========================================
  Files        2048      941     -1107     
  Lines      125310    54765    -70545     
===========================================
- Hits        44672    34298    -10374     
+ Misses      80638    20467    -60171     
Files with missing lines Coverage Δ
...inglabs-malware-presence/src/connector/__init__.py 100.00% <100.00%> (ø)
...inglabs-malware-presence/src/connector/settings.py 100.00% <100.00%> (ø)
...nglabs-malware-presence/src/connector/connector.py 9.69% <9.69%> (ø)

... and 1311 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@throuxel throuxel force-pushed the feat/reversinglabs-malware-presence-migration branch from f753055 to aa48841 Compare July 1, 2026 14:57
@throuxel throuxel force-pushed the feat/reversinglabs-malware-presence-migration branch from aa48841 to 1bf4334 Compare July 1, 2026 14:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the ReversingLabs Malware Presence internal-enrichment connector toward catalog/manager readiness by refactoring the runtime entrypoint, introducing connectors-sdk based settings/schema artifacts, and adding a basic pytest suite to validate settings and instantiation.

Changes:

  • Refactor connector entrypoint to build ConnectorSettings + OpenCTIConnectorHelper, instantiate ReversingLabsConnector, and call run().
  • Add connectors-sdk based ConnectorSettings and generated config schema/docs for catalog usage.
  • Add initial unit tests (settings validation + main wiring) and test requirements.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
internal-enrichment/reversinglabs-malware-presence/src/main.py New lightweight entrypoint that initializes settings/helper and runs the connector.
internal-enrichment/reversinglabs-malware-presence/src/connector/connector.py Connector logic moved into a dedicated module and adapted to receive config/helper.
internal-enrichment/reversinglabs-malware-presence/src/connector/settings.py Introduces connectors-sdk Pydantic settings models for OpenCTI/connector/ReversingLabs config.
internal-enrichment/reversinglabs-malware-presence/src/connector/init.py Exposes ReversingLabsConnector and ConnectorSettings for simplified imports.
internal-enrichment/reversinglabs-malware-presence/src/init.py Package export for settings.
internal-enrichment/reversinglabs-malware-presence/requirements.txt Adds connectors-sdk + pydantic dependency for the new settings models.
internal-enrichment/reversinglabs-malware-presence/Dockerfile Adjusts image layout/workdir and switches to CMD ["python3","main.py"].
internal-enrichment/reversinglabs-malware-presence/entrypoint.sh Removes legacy entrypoint script (now using Docker CMD directly).
internal-enrichment/reversinglabs-malware-presence/docker-compose.yml Updates env var sample layout to reflect new defaults/optionality.
internal-enrichment/reversinglabs-malware-presence/config.yml.sample Adds a connectors-sdk compatible YAML config sample.
internal-enrichment/reversinglabs-malware-presence/.env.sample Adds a connectors-sdk compatible env var sample.
internal-enrichment/reversinglabs-malware-presence/metadata/connector_manifest.json Marks connector as manager_supported: true for catalog/manager deployment.
internal-enrichment/reversinglabs-malware-presence/metadata/connector_config_schema.json Adds generated JSON schema describing all supported env vars.
internal-enrichment/reversinglabs-malware-presence/metadata/CONNECTOR_CONFIG_DOC.md Adds generated Markdown documentation for connector configuration.
internal-enrichment/reversinglabs-malware-presence/tests/conftest.py Test bootstrap to import connector code from src/.
internal-enrichment/reversinglabs-malware-presence/tests/test_main.py Tests wiring: settings instantiation, helper instantiation, connector instantiation.
internal-enrichment/reversinglabs-malware-presence/tests/tests_connector/test_settings.py Tests settings validation for valid/invalid config dicts.
internal-enrichment/reversinglabs-malware-presence/tests/test-requirements.txt Adds pytest + includes connector requirements for tests.
internal-enrichment/reversinglabs-malware-presence/tests/tests_connector/init.py Test package marker.

@jabesq jabesq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Remove the lib package, which is no longer used

@throuxel throuxel changed the title feat(reversinglabs malware presence): add to catalog (#6837) feat(reversinglabs-malware-presence): add to catalog (#6837) Jul 6, 2026
@throuxel throuxel force-pushed the feat/reversinglabs-malware-presence-migration branch from 7b5647a to 205be9e Compare July 6, 2026 14:33
@throuxel throuxel requested a review from jabesq July 7, 2026 07:12

@jabesq jabesq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@throuxel throuxel merged commit 4d00fd4 into master Jul 8, 2026
34 of 37 checks passed
@throuxel throuxel deleted the feat/reversinglabs-malware-presence-migration branch July 8, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ReversingLabs Malware Presence): migrate connector to the catalog

4 participants