feat(backend/frontend): split CE/EE workflows features (#16388)

Co-authored-by: Florian Delemarre <florian.delemarre@gmail.com>

Author: OctaveLaventure

opencti-platform/opencti-front/src/private/components/settings/sub_types/workflow/StatusForm.test.tsx

@@ -0,0 +1,134 @@
+import React from 'react';
+import { beforeEach, describe, it, expect, vi } from 'vitest';
+import { screen } from '@testing-library/react';
+import { Formik, Form } from 'formik';
+import StatusForm from './StatusForm';
+import testRender from '../../../../../utils/tests/test-render';
+import { WorkflowActionType } from './utils';
+import type { WorkflowEditionFormValues } from './WorkflowEditionDrawer';
+import useEnterpriseEdition from '../../../../../utils/hooks/useEnterpriseEdition';
+
+// ---------------------------------------------------------------------------
+// Mocks
+// ---------------------------------------------------------------------------
+vi.mock('./WorkflowFieldList', () => ({
+  default: () => <div data-testid="workflow-field-list" />,
+}));
+
+vi.mock('@components/common/form/StatusTemplateField', () => ({
+  default: () => <div data-testid="status-template-field" />,
+}));
+
+vi.mock('../../../../../utils/hooks/useEnterpriseEdition', () => ({
+  default: vi.fn(),
+}));
+
+vi.mock('../../../common/entreprise_edition/EEChip', () => ({
+  default: () => <span data-testid="ee-chip" />,
+}));
+
+// ---------------------------------------------------------------------------
+// Helper
+// ---------------------------------------------------------------------------
+const renderForm = (initialValues: Partial<WorkflowEditionFormValues>, onSubmit = vi.fn()) => {
+  return testRender(
+    <Formik initialValues={initialValues as WorkflowEditionFormValues} onSubmit={onSubmit}>
+      <Form>
+        <StatusForm />
+      </Form>
+    </Formik>,
+  );
+};
+
+// ---------------------------------------------------------------------------
+// Tests
+// ---------------------------------------------------------------------------
+describe('StatusForm – EE / CE gating', () => {
+  const onEnterAction = [{ type: WorkflowActionType.updateAuthorizedMembers, params: { authorized_members: [] } }];
+  const onExitAction = [{ type: WorkflowActionType.updateAuthorizedMembers, params: { authorized_members: [] } }];
+
+  describe('in Community Edition', () => {
+    beforeEach(() => {
+      vi.mocked(useEnterpriseEdition).mockReturnValue(false);
+    });
+
+    it('disables the "Update authorized members on enter" switch', () => {
+      renderForm({ onEnter: [], onExit: [] });
+      const sw = screen.getByRole('checkbox', { name: /update authorized members on enter/i }) as HTMLInputElement;
+      expect(sw.disabled).toBe(true);
+    });
+
+    it('disables the "Update authorized members on exit" switch', () => {
+      renderForm({ onEnter: [], onExit: [] });
+      const sw = screen.getByRole('checkbox', { name: /update authorized members on exit/i }) as HTMLInputElement;
+      expect(sw.disabled).toBe(true);
+    });
+
+    it('renders EEChip labels on both action sections', () => {
+      renderForm({ onEnter: [], onExit: [] });
+      // At minimum, both section headers contain "EE" marker text
+      expect(screen.getByText(/on enter actions/i)).toBeDefined();
+      expect(screen.getByText(/on exit actions/i)).toBeDefined();
+      // The switches must remain disabled
+      expect((screen.getByRole('checkbox', { name: /on enter/i }) as HTMLInputElement).disabled).toBe(true);
+    });
+  });
+
+  describe('in Enterprise Edition', () => {
+    beforeEach(() => {
+      vi.mocked(useEnterpriseEdition).mockReturnValue(true);
+    });
+
+    it('enables the "Update authorized members on enter" switch', () => {
+      renderForm({ onEnter: [], onExit: [] });
+      const sw = screen.getByRole('checkbox', { name: /update authorized members on enter/i }) as HTMLInputElement;
+      expect(sw.disabled).toBe(false);
+    });
+
+    it('enables the "Update authorized members on exit" switch', () => {
+      renderForm({ onEnter: [], onExit: [] });
+      const sw = screen.getByRole('checkbox', { name: /update authorized members on exit/i }) as HTMLInputElement;
+      expect(sw.disabled).toBe(false);
+    });
+
+    it('shows WorkflowFieldList for onEnter when action is toggled on', () => {
+      renderForm({ onEnter: onEnterAction, onExit: [] });
+      expect(screen.getAllByTestId('workflow-field-list').length).toBeGreaterThanOrEqual(1);
+    });
+
+    it('shows WorkflowFieldList for onExit when action is toggled on', () => {
+      renderForm({ onEnter: [], onExit: onExitAction });
+      expect(screen.getAllByTestId('workflow-field-list').length).toBeGreaterThanOrEqual(1);
+    });
+  });
+
+  describe('switch checked state reflects form values', () => {
+    beforeEach(() => {
+      vi.mocked(useEnterpriseEdition).mockReturnValue(true);
+    });
+
+    it('"on enter" switch is unchecked when onEnter is empty', () => {
+      renderForm({ onEnter: [], onExit: [] });
+      const sw = screen.getByRole('checkbox', { name: /update authorized members on enter/i }) as HTMLInputElement;
+      expect(sw.checked).toBe(false);
+    });
+
+    it('"on enter" switch is checked when onEnter contains updateAuthorizedMembers', () => {
+      renderForm({ onEnter: onEnterAction, onExit: [] });
+      const sw = screen.getByRole('checkbox', { name: /update authorized members on enter/i }) as HTMLInputElement;
+      expect(sw.checked).toBe(true);
+    });
+
+    it('"on exit" switch is unchecked when onExit is empty', () => {
+      renderForm({ onEnter: [], onExit: [] });
+      const sw = screen.getByRole('checkbox', { name: /update authorized members on exit/i }) as HTMLInputElement;
+      expect(sw.checked).toBe(false);
+    });
+
+    it('"on exit" switch is checked when onExit contains updateAuthorizedMembers', () => {
+      renderForm({ onEnter: [], onExit: onExitAction });
+      const sw = screen.getByRole('checkbox', { name: /update authorized members on exit/i }) as HTMLInputElement;
+      expect(sw.checked).toBe(true);
+    });
+  });
+});

opencti-platform/opencti-front/src/private/components/settings/sub_types/workflow/StatusForm.tsx

@@ -4,10 +4,13 @@ import StatusTemplateField from '@components/common/form/StatusTemplateField';
 import { WorkflowEditionFormValues } from './WorkflowEditionDrawer';
 import { Box, FormControlLabel, Switch, Typography } from '@mui/material';
 import WorkflowFieldList from './WorkflowFieldList';
-import { WorkflowActionType, WorkflowDataType } from './utils';
+import { FEATURE_NAME, WorkflowActionType, WorkflowDataType } from './utils';
+import useEnterpriseEdition from '../../../../../utils/hooks/useEnterpriseEdition';
+import EEChip from '../../../common/entreprise_edition/EEChip';
 
 const StatusForm = () => {
   const { t_i18n } = useFormatter();
+  const isEnterpriseEdition = useEnterpriseEdition();
   const { values, setFieldValue } = useFormikContext<WorkflowEditionFormValues>();
   const hasUpdateAuthorizedMembersOnEnter = values.onEnter?.some((a) => a.type === WorkflowActionType.updateAuthorizedMembers);
   const hasUpdateAuthorizedMembersOnExit = values.onExit?.some((a) => a.type === WorkflowActionType.updateAuthorizedMembers);
@@ -30,29 +33,31 @@ const StatusForm = () => {
         setFieldValue={(field, { value, label, color }) => setFieldValue(field, { id: value, name: label, color })}
         helpertext=""
       />
-      <Box sx={{ display: 'flex', flexDirection: 'column', gap: 1, marginTop: 2 }}>
+      <Box sx={{ display: 'flex', flexDirection: 'column', gap: 1, marginTop: 1 }}>
         <Typography variant="h6">
-          {t_i18n('On enter actions')}
+          {t_i18n('On enter actions')} <EEChip feature={t_i18n(FEATURE_NAME)} />
         </Typography>
         <FormControlLabel
           control={(
             <Switch
               checked={hasUpdateAuthorizedMembersOnEnter}
+              disabled={!isEnterpriseEdition}
               onChange={(e) => handleToggleUpdateAuthorizedMembers('onEnter', e.target.checked)}
             />
           )}
           label={t_i18n('Update authorized members on enter')}
         />
         {hasUpdateAuthorizedMembersOnEnter && <WorkflowFieldList name={WorkflowDataType.onEnter} />}
       </Box>
-      <Box sx={{ display: 'flex', flexDirection: 'column', gap: 1, marginTop: 2 }}>
+      <Box sx={{ display: 'flex', flexDirection: 'column', gap: 1, marginTop: 1 }}>
         <Typography variant="h6">
-          {t_i18n('On exit actions')}
+          {t_i18n('On exit actions')} <EEChip feature={t_i18n(FEATURE_NAME)} />
         </Typography>
         <FormControlLabel
           control={(
             <Switch
               checked={hasUpdateAuthorizedMembersOnExit}
+              disabled={!isEnterpriseEdition}
               onChange={(e) => handleToggleUpdateAuthorizedMembers('onExit', e.target.checked)}
             />
           )}

opencti-platform/opencti-front/src/private/components/settings/sub_types/workflow/TransitionForm.test.tsx

@@ -1,12 +1,13 @@
 import React from 'react';
-import { describe, it, expect, vi } from 'vitest';
+import { beforeEach, describe, it, expect, vi } from 'vitest';
 import { screen, waitFor } from '@testing-library/react';
 import { Formik, Form } from 'formik';
 import TransitionForm from './TransitionForm';
 import testRender from '../../../../../utils/tests/test-render';
 import { WorkflowActionType, CommentMode } from './utils';
 import type { WorkflowEditionFormValues } from './WorkflowEditionDrawer';
 import type { FilterGroup } from '../../../../../utils/filters/filtersHelpers-types';
+import useEnterpriseEdition from '../../../../../utils/hooks/useEnterpriseEdition';
 
 // ---------------------------------------------------------------------------
 // Mock heavy sub-components with no relevance to the tested logic
@@ -23,6 +24,18 @@ vi.mock('../../../../../components/TextField', () => ({
   default: ({ field }: { field: { name: string } }) => <input data-testid={`field-${field.name}`} />,
 }));
 
+vi.mock('../../../../../utils/hooks/useEnterpriseEdition', () => ({
+  default: vi.fn(),
+}));
+
+vi.mock('../../../common/entreprise_edition/EEChip', () => ({
+  default: () => <span data-testid="ee-chip" />,
+}));
+
+vi.mock('../../../common/form/ObjectOrganizationField', () => ({
+  default: () => <div data-testid="object-organization-field" />,
+}));
+
 // ---------------------------------------------------------------------------
 // Helper: render TransitionForm inside a Formik context
 // ---------------------------------------------------------------------------
@@ -40,6 +53,10 @@ const renderForm = (initialValues: Partial<WorkflowEditionFormValues>, onSubmit
 // Tests
 // ---------------------------------------------------------------------------
 describe('TransitionForm – comment section', () => {
+  beforeEach(() => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(true);
+  });
+
   it('renders "Enable comment" switch unchecked when comment is "disable"', () => {
     renderForm({ event: 'approve', comment: CommentMode.disabled, syncActions: [] });
     const enableSwitch = screen.getByRole('checkbox', { name: /enable comment/i });
@@ -146,6 +163,10 @@ describe('TransitionForm – comment section', () => {
 });
 
 describe('TransitionForm – action toggles', () => {
+  beforeEach(() => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(true);
+  });
+
   it('"Update authorized members" switch is unchecked when action is absent', () => {
     renderForm({ event: 'approve', comment: CommentMode.disabled, syncActions: [] });
     const uamSwitch = screen.getByRole('checkbox', { name: /update authorized members/i });
@@ -256,6 +277,10 @@ describe('TransitionForm – action toggles', () => {
 });
 
 describe('TransitionForm – rendering', () => {
+  beforeEach(() => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(true);
+  });
+
   it('renders the transition name field', () => {
     renderForm({ event: 'approve', comment: CommentMode.disabled, syncActions: [] });
     expect(screen.getByTestId('field-event')).toBeDefined();
@@ -282,3 +307,78 @@ describe('TransitionForm – rendering', () => {
     expect(screen.getByTestId('workflow-field-list')).toBeDefined();
   });
 });
+
+// ---------------------------------------------------------------------------
+// EE / CE gating
+// ---------------------------------------------------------------------------
+describe('TransitionForm – EE / CE gating', () => {
+  const emptyFilterGroup: FilterGroup = { mode: 'and', filters: [], filterGroups: [] };
+  const eeActions = [{ type: WorkflowActionType.updateAuthorizedMembers, params: { authorized_members: [] } }];
+
+  it('disables EE-only switches in CE', () => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(false);
+    renderForm({ event: 'close', comment: CommentMode.disabled, syncActions: [], asyncActions: [] });
+
+    expect((screen.getByRole('checkbox', { name: /update authorized members/i }) as HTMLInputElement).disabled).toBe(true);
+    expect((screen.getByRole('checkbox', { name: /share with organizations/i }) as HTMLInputElement).disabled).toBe(true);
+    expect((screen.getByRole('checkbox', { name: /unshare from organizations/i }) as HTMLInputElement).disabled).toBe(true);
+  });
+
+  it('enables EE-only switches in EE', () => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(true);
+    renderForm({ event: 'close', comment: CommentMode.disabled, syncActions: [], asyncActions: [] });
+
+    expect((screen.getByRole('checkbox', { name: /update authorized members/i }) as HTMLInputElement).disabled).toBe(false);
+    expect((screen.getByRole('checkbox', { name: /share with organizations/i }) as HTMLInputElement).disabled).toBe(false);
+    expect((screen.getByRole('checkbox', { name: /unshare from organizations/i }) as HTMLInputElement).disabled).toBe(false);
+  });
+
+  it('"Validate draft" switch is always enabled regardless of EE status', () => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(false);
+    renderForm({ event: 'close', comment: CommentMode.disabled, syncActions: [] });
+
+    expect((screen.getByRole('checkbox', { name: /validate draft/i }) as HTMLInputElement).disabled).toBe(false);
+  });
+
+  it('renders the conditions block with pointer-events:none in CE', () => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(false);
+    renderForm({ event: 'close', comment: CommentMode.disabled, syncActions: [], conditions: { filters: emptyFilterGroup } });
+
+    const conditionFilters = screen.getByTestId('workflow-condition-filters');
+    const wrapper = conditionFilters.parentElement!;
+    expect(wrapper.style.pointerEvents).toBe('none');
+    expect(wrapper.style.opacity).toBe('0.5');
+  });
+
+  it('renders the conditions block without pointer-events restriction in EE', () => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(true);
+    renderForm({ event: 'close', comment: CommentMode.disabled, syncActions: [], conditions: { filters: emptyFilterGroup } });
+
+    const conditionFilters = screen.getByTestId('workflow-condition-filters');
+    const wrapper = conditionFilters.parentElement!;
+    // 'auto' is CSS default so it serializes as '' in jsdom; just confirm it's not 'none'
+    expect(wrapper.style.pointerEvents).not.toBe('none');
+    expect(wrapper.style.opacity).not.toBe('0.5');
+  });
+
+  it('renders the WorkflowFieldList with pointer-events:none in CE when EE actions exist', () => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(false);
+    renderForm({ event: 'close', comment: CommentMode.disabled, syncActions: eeActions });
+
+    const fieldList = screen.getByTestId('workflow-field-list');
+    const wrapper = fieldList.parentElement!;
+    expect(wrapper.style.pointerEvents).toBe('none');
+    expect(wrapper.style.opacity).toBe('0.5');
+  });
+
+  it('renders the WorkflowFieldList without pointer-events restriction in EE', () => {
+    vi.mocked(useEnterpriseEdition).mockReturnValue(true);
+    renderForm({ event: 'close', comment: CommentMode.disabled, syncActions: eeActions });
+
+    const fieldList = screen.getByTestId('workflow-field-list');
+    const wrapper = fieldList.parentElement!;
+    // 'auto' is CSS default so it serializes as '' in jsdom; just confirm it's not 'none'
+    expect(wrapper.style.pointerEvents).not.toBe('none');
+    expect(wrapper.style.opacity).not.toBe('0.5');
+  });
+});