Skip to content

[frontend] prevent re-rending of settings right menu (#15339)#15345

Open
frapuks wants to merge 4 commits intomasterfrom
issue/15339
Open

[frontend] prevent re-rending of settings right menu (#15339)#15345
frapuks wants to merge 4 commits intomasterfrom
issue/15339

Conversation

@frapuks
Copy link
Copy Markdown
Member

@frapuks frapuks commented Apr 2, 2026

Proposed changes

  • prevent rerending of settings right menu
    • customization
    • vocabularies
    • activity

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@frapuks frapuks self-assigned this Apr 2, 2026
@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Apr 2, 2026
@frapuks frapuks linked an issue Apr 2, 2026 that may be closed by this pull request
3 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.61%. Comparing base (c122c45) to head (736d727).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
.../private/components/settings/vocabularies/Root.tsx 0.00% 23 Missing ⚠️
...private/components/settings/customization/Root.tsx 0.00% 17 Missing ⚠️
.../src/private/components/settings/activity/Root.tsx 0.00% 7 Missing ⚠️
...cti-front/src/private/components/settings/Root.tsx 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15345      +/-   ##
==========================================
- Coverage   32.63%   32.61%   -0.02%     
==========================================
  Files        3149     3153       +4     
  Lines      213825   214697     +872     
  Branches    38796    38948     +152     
==========================================
+ Hits        69773    70015     +242     
- Misses     144052   144682     +630     
Flag Coverage Δ
opencti-client-python 44.48% <ø> (-1.05%) ⬇️
opencti-front 2.87% <0.00%> (+<0.01%) ⬆️
opencti-graphql 67.96% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frapuks frapuks changed the title [frontend] prevent rerending of customization menu (#15339) [frontend] prevent re-rending of settings right menu (#15339) Apr 2, 2026
@frapuks frapuks marked this pull request as ready for review April 2, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent re-rendering Settings right menu

2 participants