Skip to content

[backend] remove LRU session cache in redis session store (#13855) #15362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xfournet merged 1 commit into from
May 5, 2026
Merged

[backend] remove LRU session cache in redis session store (#13855) #15362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions opencti-platform/opencti-graphql/src/database/sessionStore-redis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,20 @@ class RedisStore extends Store {
this.prefix = options.prefix == null ? 'sess:' : options.prefix;
this.scanCount = Number(options.scanCount) || 100;
this.serializer = options.serializer || JSON;
this.cache = new LRUCache({ ttl: 2500, max: 1000 }); // Force refresh the session every 2.5 sec
this.touchCache = new LRUCache({ ttl: 120000, max: 1000 }); // Touch the session every 2 minutes
this.locker = new AsyncLock();
}

get(sid, cb = noop) {
const key = this.prefix + sid;
const { cache } = this;
const sessionFetcher = (done) => {
const cachedSession = cache.get(`get-${key}`);
if (cachedSession) {
return done(null, cachedSession);
}
return getSession(key).then((data) => {
const sessionFetcher = async (done) => {
try {
let data = await getSession(key);
Copy link
Copy Markdown
Member

@xfournet xfournet Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const ?

if (!data) return done();
cache.set(`get-${key}`, data);
return done(null, data);
}).catch((error) => {
} catch (error) {
return done(error, null);
});
}
};
this.locker.acquire(key, sessionFetcher, (error, result) => {
return cb(error, result);
Expand All @@ -44,12 +38,9 @@ class RedisStore extends Store {

set(sid, sess, cb = noop) {
const key = this.prefix + sid;
const { cache } = this;
const sessionSetter = (done) => {
return setSession(key, sess, this.ttl).then((data) => {
cache.set(`get-${key}`, data);
return done(null, data);
});
const sessionSetter = async (done) => {
const data = await setSession(key, sess, this.ttl);
return done(null, data);
};
return this.locker.acquire(key, sessionSetter, (error, result) => {
return cb(error, result);
Expand Down
Loading