Skip to content

[backend/frontend] Remove FINTEL_FOR_ENTITY feature flag (#15210)#15368

Merged
delemaf merged 1 commit into
masterfrom
issue/15210-remove-ff
Apr 9, 2026
Merged

[backend/frontend] Remove FINTEL_FOR_ENTITY feature flag (#15210)#15368
delemaf merged 1 commit into
masterfrom
issue/15210-remove-ff

Conversation

@delemaf
Copy link
Copy Markdown
Member

@delemaf delemaf commented Apr 3, 2026

Proposed changes

  • Remove FINTEL_FOR_ENTITY feature flag

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@delemaf delemaf self-assigned this Apr 3, 2026
@github-actions github-actions Bot added the filigran team use to identify PR from the Filigran team label Apr 3, 2026
@delemaf delemaf linked an issue Apr 3, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.28%. Comparing base (bd4e032) to head (96bbc58).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15368   +/-   ##
=======================================
  Coverage   33.28%   33.28%           
=======================================
  Files        3164     3164           
  Lines      214342   214332   -10     
  Branches    39211    39207    -4     
=======================================
+ Hits        71334    71335    +1     
+ Misses     143008   142997   -11     
Flag Coverage Δ
opencti-client-python 45.60% <ø> (ø)
opencti-front 2.85% <ø> (-0.01%) ⬇️
opencti-graphql 69.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from issue/15366-nx-analytics-config to master April 6, 2026 19:24
@delemaf delemaf requested a review from Copilot April 9, 2026 09:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the FINTEL_FOR_ENTITY feature flag, which previously allowed toggling between two modes: one where Fintel templates work with both containers and entities, and another where they work only with containers. The removal means the feature flag state "FINTEL_FOR_ENTITY enabled" becomes the permanent behavior.

Changes:

  • Removed feature flag conditionals from backend fintelTemplate domain logic, now always treating templates as entity-capable
  • Removed feature flag conditionals from frontend hooks and components, simplifying the type lists and tooltip messages to use the "entity" behavior
  • Removed related imports (useHelper) and constants (typesWithFintelTemplatesContainer) that were only needed for the feature flag check
  • Added unrelated analytics: false configuration to nx.json

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
opencti-platform/opencti-graphql/src/modules/fintelTemplate/fintelTemplate-domain.ts Removes feature flag check, always uses isStixDomainObjectContainer() for widget selection
opencti-platform/opencti-front/src/utils/hooks/useAttributes.ts Removes conditional logic, directly exports typesWithFintelTemplates without feature flag checking
opencti-platform/opencti-front/src/private/components/settings/sub_types/SubTypeOverview.tsx Removes outdated comment about feature flag removal
opencti-platform/opencti-front/src/components/FilterValuesContent.tsx Simplifies tooltip to always show entity context message
nx.json Adds unrelated analytics configuration

Comment thread nx.json
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"defaultBase": "master"
"defaultBase": "master",
"analytics": false
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of "analytics": false to nx.json appears to be unrelated to the feature flag removal purpose of this PR. This change should either be removed (if unintended) or moved to a separate PR for clarity. Feature flag removal PRs should focus on that specific change to maintain clear commit history and easier code review.

Copilot uses AI. Check for mistakes.
@delemaf delemaf force-pushed the issue/15210-remove-ff branch from 4bc2344 to 96bbc58 Compare April 9, 2026 09:41
@delemaf delemaf merged commit 7f597f9 into master Apr 9, 2026
41 checks passed
@delemaf delemaf deleted the issue/15210-remove-ff branch April 9, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix filters for related data

3 participants