[backend/frontend] Remove FINTEL_FOR_ENTITY feature flag (#15210)#15368
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #15368 +/- ##
=======================================
Coverage 33.28% 33.28%
=======================================
Files 3164 3164
Lines 214342 214332 -10
Branches 39211 39207 -4
=======================================
+ Hits 71334 71335 +1
+ Misses 143008 142997 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the FINTEL_FOR_ENTITY feature flag, which previously allowed toggling between two modes: one where Fintel templates work with both containers and entities, and another where they work only with containers. The removal means the feature flag state "FINTEL_FOR_ENTITY enabled" becomes the permanent behavior.
Changes:
- Removed feature flag conditionals from backend fintelTemplate domain logic, now always treating templates as entity-capable
- Removed feature flag conditionals from frontend hooks and components, simplifying the type lists and tooltip messages to use the "entity" behavior
- Removed related imports (
useHelper) and constants (typesWithFintelTemplatesContainer) that were only needed for the feature flag check - Added unrelated
analytics: falseconfiguration to nx.json
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| opencti-platform/opencti-graphql/src/modules/fintelTemplate/fintelTemplate-domain.ts | Removes feature flag check, always uses isStixDomainObjectContainer() for widget selection |
| opencti-platform/opencti-front/src/utils/hooks/useAttributes.ts | Removes conditional logic, directly exports typesWithFintelTemplates without feature flag checking |
| opencti-platform/opencti-front/src/private/components/settings/sub_types/SubTypeOverview.tsx | Removes outdated comment about feature flag removal |
| opencti-platform/opencti-front/src/components/FilterValuesContent.tsx | Simplifies tooltip to always show entity context message |
| nx.json | Adds unrelated analytics configuration |
| "$schema": "./node_modules/nx/schemas/nx-schema.json", | ||
| "defaultBase": "master" | ||
| "defaultBase": "master", | ||
| "analytics": false |
There was a problem hiding this comment.
The addition of "analytics": false to nx.json appears to be unrelated to the feature flag removal purpose of this PR. This change should either be removed (if unintended) or moved to a separate PR for clarity. Feature flag removal PRs should focus on that specific change to maintain clear commit history and easier code review.
4bc2344 to
96bbc58
Compare
Proposed changes
FINTEL_FOR_ENTITYfeature flagRelated issues
Checklist
Further comments