Skip to content

feat: a SecurityCoverage can have multiple associated results (#14716)#16072

Draft
MTorbay-Filigran wants to merge 4 commits into
masterfrom
issue/14716-sc-multitenant
Draft

feat: a SecurityCoverage can have multiple associated results (#14716)#16072
MTorbay-Filigran wants to merge 4 commits into
masterfrom
issue/14716-sc-multitenant

Conversation

@MTorbay-Filigran

@MTorbay-Filigran MTorbay-Filigran commented May 19, 2026

Copy link
Copy Markdown
Member

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn lndrtrbn added the filigran team Item from the Filigran team. label May 19, 2026
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 22.88557% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.66%. Comparing base (eb807ac) to head (97e4f01).

Files with missing lines Patch % Lines
...pycti/entities/opencti_security_coverage_result.py 15.00% 85 Missing ⚠️
...ityCoverageResult/securityCoverageResult-domain.ts 18.75% 26 Missing ⚠️
...odules/securityCoverage/securityCoverage-domain.ts 17.85% 23 Missing ⚠️
...ules/securityCoverage/securityCoverage-resolver.ts 0.00% 9 Missing ⚠️
...yCoverageResult/securityCoverageResult-resolver.ts 20.00% 4 Missing ⚠️
...e/securityCoverageResult/securityCoverageResult.ts 60.00% 4 Missing ⚠️
...l/src/modules/securityCoverage/securityCoverage.ts 0.00% 2 Missing ⚠️
...platform/opencti-front/src/components/ItemIcon.tsx 0.00% 1 Missing ⚠️
...les/securityCoverage/securityCoverage-converter.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16072      +/-   ##
==========================================
- Coverage   24.51%   18.66%   -5.85%     
==========================================
  Files        3290     3297       +7     
  Lines      174583   174767     +184     
  Branches    43467    43475       +8     
==========================================
- Hits        42792    32621   -10171     
- Misses     131791   142146   +10355     
Flag Coverage Δ
opencti-client-python 46.05% <17.47%> (-0.26%) ⬇️
opencti-front 6.06% <0.00%> (-0.01%) ⬇️
opencti-graphql 44.45% <28.86%> (-22.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lndrtrbn lndrtrbn force-pushed the issue/14716-sc-multitenant branch from c29abe2 to 066e14b Compare May 20, 2026 13:59
@lndrtrbn lndrtrbn force-pushed the issue/14716-sc-multitenant branch from 6be9ec7 to 73f3ae6 Compare May 29, 2026 12:21
@lndrtrbn lndrtrbn changed the title [backend/frontend] Security Coverage : multi tenant openCTI openAEV (#14716) feat: Security Coverage - multi tenant openCTI openAEV (#14716) Jun 1, 2026
@lndrtrbn lndrtrbn changed the title feat: Security Coverage - multi tenant openCTI openAEV (#14716) feat: a SecurityCoverage can have multiple associated results (#14716) Jun 1, 2026
@SamuelHassine SamuelHassine changed the title feat: a SecurityCoverage can have multiple associated results (#14716) feat: a SecurityCoverage can have multiple associated results (#14716) (#16092) Jun 7, 2026
@SamuelHassine SamuelHassine added feature Type: new feature or capability (feat:). and removed feature Type: new feature or capability (feat:). labels Jun 7, 2026
@lndrtrbn lndrtrbn force-pushed the issue/14716-sc-multitenant branch 2 times, most recently from d96a51e to bf44edb Compare June 15, 2026 07:30
@MTorbay-Filigran MTorbay-Filigran changed the title feat: a SecurityCoverage can have multiple associated results (#14716) (#16092) feat: a SecurityCoverage can have multiple associated results (#14716) Jun 25, 2026
MTorbay-Filigran and others added 4 commits June 30, 2026 15:52
corrected counter

fix counter total

fix counter
missing import + translations

unit tests for standard id

Added UT on SecurityCoverageResult converter

fix tests fail

fix test

interface
…ults

add tests and manage delete

skip test for now

Revert "skip test for now"

This reverts commit 29dd1e5.

rewrite tests
…4716)

Co-authored-by: Souad Hadjiat <souad.hadjiat@filigran.io>
Co-authored-by: Landry Trebon <landry.trebon@filigran.io>
@lndrtrbn lndrtrbn force-pushed the issue/14716-sc-multitenant branch from bf44edb to 97e4f01 Compare June 30, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update data model

3 participants