feat: a SecurityCoverage can have multiple associated results (#14716)#16072
Draft
MTorbay-Filigran wants to merge 4 commits into
Draft
feat: a SecurityCoverage can have multiple associated results (#14716)#16072MTorbay-Filigran wants to merge 4 commits into
MTorbay-Filigran wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16072 +/- ##
==========================================
- Coverage 24.51% 18.66% -5.85%
==========================================
Files 3290 3297 +7
Lines 174583 174767 +184
Branches 43467 43475 +8
==========================================
- Hits 42792 32621 -10171
- Misses 131791 142146 +10355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c29abe2 to
066e14b
Compare
6be9ec7 to
73f3ae6
Compare
d96a51e to
bf44edb
Compare
corrected counter fix counter total fix counter
missing import + translations unit tests for standard id Added UT on SecurityCoverageResult converter fix tests fail fix test interface
…ults add tests and manage delete skip test for now Revert "skip test for now" This reverts commit 29dd1e5. rewrite tests
…4716) Co-authored-by: Souad Hadjiat <souad.hadjiat@filigran.io> Co-authored-by: Landry Trebon <landry.trebon@filigran.io>
bf44edb to
97e4f01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist