Cyclic dependency when building shared libraries

[bkmgit]

Describe the bug

CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle):
  "LLVMipo" of type SHARED_LIBRARY
    depends on "LLVMTapirOpts" (weak)
  "LLVMTapirOpts" of type SHARED_LIBRARY
    depends on "LLVMipo" (weak)
At least one of these targets is not a STATIC_LIBRARY.  Cyclic dependencies are allowed only among static libraries.
CMake Generate step failed.  Build files cannot be regenerated correctly.

Expected behavior

CMake should be able to resolve dependencies

OpenCilk version

Built from source:

• 3,0-rc2

System information

• OS: Fedora Rawhide (43)
• CPU: x86_64, Aarch64

Steps to reproduce (include relevant output)

https://koji.fedoraproject.org/koji/taskinfo?taskID=132305620
https://kojipkgs.fedoraproject.org//work/tasks/5762/132305762/build.log

[neboat]

Thanks for the bug report.

I'm currently testing a fix for this issue in PR #332 on our own battery of regression and application tests. While those tests are running, if you can, please try out that change and let us know if it fixes the problem on your end.

[bkmgit]

Thanks. The patch fixes the problem:
https://koji.fedoraproject.org/koji/taskinfo?taskID=132314713
https://kojipkgs.fedoraproject.org//work/tasks/4173/132314173/build.log

https://koji.fedoraproject.org/koji/taskinfo?taskID=132314078
https://kojipkgs.fedoraproject.org//work/tasks/4798/132314798/build.log

Trying to figure out reason for next error.

[neboat]

Glad to hear it! I might have found a simpler patch for the original issue. But if the existing patch works for you, I think it should be fine.

I did a little search, and it looks like the standard LLVM RPM source includes a patch for the part of the code causing the new build failure: https://src.fedoraproject.org/rpms/llvm/blob/rawhide/f/0001-sanitizer_common-Remove-interceptors-for-deprecated-.patch. For Fedora, I think you should be able to patch the OpenCilk compiler source with the same LLVM patches. Does that patch work for you?