test: keep command setup hook tests narrow

Author: steipete

src/commands/onboard-channels.post-write.test.ts

@@ -1,137 +1,52 @@
-import { beforeEach, describe, expect, it, vi } from "vitest";
+import { describe, expect, it, vi } from "vitest";
 import type { OpenClawConfig } from "../config/config.js";
-import { setActivePluginRegistry } from "../plugins/runtime.js";
-import { createChannelTestPluginBase, createTestRegistry } from "../test-utils/channel-plugins.js";
-import type { WizardPrompter } from "../wizard/prompts.js";
-import { patchChannelSetupWizardAdapter } from "./channel-test-helpers.js";
 import {
+  createChannelOnboardingPostWriteHook,
   createChannelOnboardingPostWriteHookCollector,
   runCollectedChannelOnboardingPostWriteHooks,
-  setupChannels,
 } from "./onboard-channels.js";
-import { createExitThrowingRuntime, createWizardPrompter } from "./test-wizard-helpers.js";
-
-function setMinimalTelegramOnboardingRegistryForTests(): void {
-  setActivePluginRegistry(
-    createTestRegistry([
-      {
-        pluginId: "telegram",
-        source: "test",
-        plugin: {
-          ...createChannelTestPluginBase({
-            id: "telegram",
-            label: "Telegram",
-            capabilities: { chatTypes: ["direct", "group"] },
-          }),
-          setup: {
-            applyAccountConfig: ({ cfg }: { cfg: OpenClawConfig }) => cfg,
-          },
-          setupWizard: {
-            channel: "telegram",
-            status: {
-              configuredLabel: "Configured",
-              unconfiguredLabel: "Not configured",
-              resolveConfigured: ({ cfg }: { cfg: OpenClawConfig }) =>
-                Boolean(cfg.channels?.telegram?.botToken),
-            },
-            credentials: [],
-          },
-        },
-      },
-    ]),
-  );
-}
-
-function createPrompter(overrides: Partial<WizardPrompter>): WizardPrompter {
-  return createWizardPrompter(
-    {
-      progress: vi.fn(() => ({ update: vi.fn(), stop: vi.fn() })),
-      ...overrides,
-    },
-    { defaultSelect: "__done__" },
-  );
-}
-
-function createQuickstartTelegramSelect() {
-  return vi.fn(async ({ message }: { message: string }) => {
-    if (message === "Select channel (QuickStart)") {
-      return "telegram";
-    }
-    return "__done__";
-  });
-}
-
-function createUnexpectedQuickstartPrompter(select: WizardPrompter["select"]) {
-  return createPrompter({
-    select,
-    multiselect: vi.fn(async () => {
-      throw new Error("unexpected multiselect");
-    }),
-    text: vi.fn(async ({ message }: { message: string }) => {
-      throw new Error(`unexpected text prompt: ${message}`);
-    }) as unknown as WizardPrompter["text"],
-  });
-}
+import { createExitThrowingRuntime } from "./test-wizard-helpers.js";
 
 describe("setupChannels post-write hooks", () => {
-  beforeEach(() => {
-    setMinimalTelegramOnboardingRegistryForTests();
-  });
-
   it("collects onboarding post-write hooks and runs them against the final config", async () => {
-    const select = createQuickstartTelegramSelect();
     const afterConfigWritten = vi.fn(async () => {});
-    const configureInteractive = vi.fn(async ({ cfg }: { cfg: OpenClawConfig }) => ({
-      cfg: {
-        ...cfg,
-        channels: {
-          ...cfg.channels,
-          telegram: { ...cfg.channels?.telegram, botToken: "new-token" },
-        },
-      } as OpenClawConfig,
-      accountId: "acct-1",
-    }));
-    const restore = patchChannelSetupWizardAdapter("telegram", {
-      configureInteractive,
+    const previousCfg = {} as OpenClawConfig;
+    const cfg = {
+      channels: {
+        telegram: { botToken: "new-token" },
+      },
+    } as OpenClawConfig;
+    const adapter = {
       afterConfigWritten,
-      getStatus: vi.fn(async ({ cfg }: { cfg: OpenClawConfig }) => ({
-        channel: "telegram",
-        configured: Boolean(cfg.channels?.telegram?.botToken),
-        statusLines: [],
-      })),
-    });
-    const prompter = createUnexpectedQuickstartPrompter(
-      select as unknown as WizardPrompter["select"],
-    );
+    };
     const collector = createChannelOnboardingPostWriteHookCollector();
     const runtime = createExitThrowingRuntime();
+    const hook = createChannelOnboardingPostWriteHook({
+      accountId: "acct-1",
+      adapter,
+      channel: "telegram",
+      previousCfg,
+    });
 
-    try {
-      const cfg = await setupChannels({} as OpenClawConfig, runtime, prompter, {
-        quickstartDefaults: true,
-        skipConfirm: true,
-        onPostWriteHook: (hook) => {
-          collector.collect(hook);
-        },
-      });
+    if (!hook) {
+      throw new Error("expected post-write hook");
+    }
+    collector.collect(hook);
 
-      expect(afterConfigWritten).not.toHaveBeenCalled();
+    expect(afterConfigWritten).not.toHaveBeenCalled();
 
-      await runCollectedChannelOnboardingPostWriteHooks({
-        hooks: collector.drain(),
-        cfg,
-        runtime,
-      });
+    await runCollectedChannelOnboardingPostWriteHooks({
+      hooks: collector.drain(),
+      cfg,
+      runtime,
+    });
 
-      expect(afterConfigWritten).toHaveBeenCalledWith({
-        previousCfg: {} as OpenClawConfig,
-        cfg,
-        accountId: "acct-1",
-        runtime,
-      });
-    } finally {
-      restore();
-    }
+    expect(afterConfigWritten).toHaveBeenCalledWith({
+      previousCfg,
+      cfg,
+      accountId: "acct-1",
+      runtime,
+    });
   });
 
   it("logs onboarding post-write hook failures without aborting", async () => {

src/commands/onboard-channels.ts

@@ -1,4 +1,5 @@
 export {
+  createChannelOnboardingPostWriteHook,
   createChannelOnboardingPostWriteHookCollector,
   noteChannelStatus,
   runCollectedChannelOnboardingPostWriteHooks,

src/flows/channel-setup.ts

@@ -4,7 +4,10 @@ import {
   getChannelSetupPlugin,
   listChannelSetupPlugins,
 } from "../channels/plugins/setup-registry.js";
-import type { ChannelSetupPlugin } from "../channels/plugins/setup-wizard-types.js";
+import type {
+  ChannelSetupPlugin,
+  ChannelSetupWizardAdapter,
+} from "../channels/plugins/setup-wizard-types.js";
 import { listChatChannels } from "../channels/registry.js";
 import { formatCliCommand } from "../cli/command-format.js";
 import {
@@ -77,6 +80,28 @@ export async function runCollectedChannelOnboardingPostWriteHooks(params: {
   }
 }
 
+export function createChannelOnboardingPostWriteHook(params: {
+  accountId?: string;
+  adapter?: Pick<ChannelSetupWizardAdapter, "afterConfigWritten">;
+  channel: ChannelChoice;
+  previousCfg: OpenClawConfig;
+}): ChannelOnboardingPostWriteHook | undefined {
+  if (!params.accountId || !params.adapter?.afterConfigWritten) {
+    return undefined;
+  }
+  return {
+    channel: params.channel,
+    accountId: params.accountId,
+    run: async ({ cfg, runtime }) =>
+      await params.adapter?.afterConfigWritten?.({
+        previousCfg: params.previousCfg,
+        cfg,
+        accountId: params.accountId!,
+        runtime,
+      }),
+  };
+}
+
 // Channel-specific prompts moved into setup flow adapters.
 
 export async function setupChannels(
@@ -336,18 +361,14 @@ export async function setupChannels(
     const adapter = getVisibleSetupFlowAdapter(channel);
     if (result.accountId) {
       recordAccount(channel, result.accountId);
-      if (adapter?.afterConfigWritten) {
-        options?.onPostWriteHook?.({
-          channel,
-          accountId: result.accountId,
-          run: async ({ cfg, runtime }) =>
-            await adapter.afterConfigWritten?.({
-              previousCfg,
-              cfg,
-              accountId: result.accountId!,
-              runtime,
-            }),
-        });
+      const postWriteHook = createChannelOnboardingPostWriteHook({
+        accountId: result.accountId,
+        adapter,
+        channel,
+        previousCfg,
+      });
+      if (postWriteHook) {
+        options?.onPostWriteHook?.(postWriteHook);
       }
     }
     addSelection(channel);