test: stabilize plugin boundary invariants

Author: steipete

src/plugins/contracts/boundary-invariants.test.ts

@@ -1,5 +1,5 @@
-import { readFileSync } from "node:fs";
-import { dirname, resolve } from "node:path";
+import { readFileSync, readdirSync } from "node:fs";
+import { dirname, relative, resolve, sep } from "node:path";
 import { fileURLToPath } from "node:url";
 import { describe, expect, it } from "vitest";
 
@@ -33,13 +33,43 @@ const ALLOWED_CHANNEL_BUNDLED_METADATA_CONSUMERS = new Set([
   "src/channels/plugins/session-conversation.bundled-fallback.test.ts",
 ]);
 
+type FileFilter = {
+  excludeTests?: boolean;
+  testOnly?: boolean;
+};
+
+function listTsFiles(rootRelativePath: string, filter: FileFilter = {}): string[] {
+  const root = resolve(REPO_ROOT, rootRelativePath);
+  const files: string[] = [];
+
+  function walk(directory: string) {
+    for (const entry of readdirSync(directory, { withFileTypes: true })) {
+      const fullPath = resolve(directory, entry.name);
+      if (entry.isDirectory()) {
+        walk(fullPath);
+        continue;
+      }
+      if (!entry.isFile() || !entry.name.endsWith(".ts")) {
+        continue;
+      }
+      const repoRelativePath = relative(REPO_ROOT, fullPath).split(sep).join("/");
+      if (filter.excludeTests && repoRelativePath.endsWith(".test.ts")) {
+        continue;
+      }
+      if (filter.testOnly && !repoRelativePath.endsWith(".test.ts")) {
+        continue;
+      }
+      files.push(repoRelativePath);
+    }
+  }
+
+  walk(root);
+  return files.toSorted();
+}
+
 describe("plugin contract boundary invariants", () => {
-  it("keeps bundled-capability-metadata confined to contract/test inventory", async () => {
-    const { globSync } = await import("glob");
-    const files = globSync("src/**/*.ts", {
-      cwd: REPO_ROOT,
-      nodir: true,
-    });
+  it("keeps bundled-capability-metadata confined to contract/test inventory", () => {
+    const files = listTsFiles("src");
     const offenders = files.filter((file) => {
       if (ALLOWED_BUNDLED_CAPABILITY_METADATA_CONSUMERS.has(file)) {
         return false;
@@ -50,26 +80,17 @@ describe("plugin contract boundary invariants", () => {
     expect(offenders).toEqual([]);
   });
 
-  it("keeps the bundled contract inventory out of non-test runtime code", async () => {
-    const { globSync } = await import("glob");
-    const files = globSync("src/**/*.ts", {
-      cwd: REPO_ROOT,
-      nodir: true,
-      ignore: ["src/**/*.test.ts"],
-    });
+  it("keeps the bundled contract inventory out of non-test runtime code", () => {
+    const files = listTsFiles("src", { excludeTests: true });
     const offenders = files.filter((file) => {
       const source = readFileSync(resolve(REPO_ROOT, file), "utf8");
       return source.includes("contracts/inventory/bundled-capability-metadata");
     });
     expect(offenders).toEqual([]);
   });
 
-  it("keeps core tests off bundled extension deep imports", async () => {
-    const { globSync } = await import("glob");
-    const files = globSync("src/**/*.test.ts", {
-      cwd: REPO_ROOT,
-      nodir: true,
-    });
+  it("keeps core tests off bundled extension deep imports", () => {
+    const files = listTsFiles("src", { testOnly: true });
     const offenders = files.filter((file) => {
       if (ALLOWED_EXTENSION_PATH_STRING_TESTS.has(file)) {
         return false;
@@ -84,12 +105,8 @@ describe("plugin contract boundary invariants", () => {
     expect(offenders).toEqual([]);
   });
 
-  it("keeps plugin contract tests off bundled path helpers unless the test is explicitly about paths", async () => {
-    const { globSync } = await import("glob");
-    const files = globSync("src/plugins/contracts/**/*.test.ts", {
-      cwd: REPO_ROOT,
-      nodir: true,
-    });
+  it("keeps plugin contract tests off bundled path helpers unless the test is explicitly about paths", () => {
+    const files = listTsFiles("src/plugins/contracts", { testOnly: true });
     const offenders = files.filter((file) => {
       if (ALLOWED_CONTRACT_BUNDLED_PATH_HELPERS.has(file)) {
         return false;
@@ -100,13 +117,8 @@ describe("plugin contract boundary invariants", () => {
     expect(offenders).toEqual([]);
   });
 
-  it("keeps channel production code off bundled-plugin-metadata helpers", async () => {
-    const { globSync } = await import("glob");
-    const files = globSync("src/channels/**/*.ts", {
-      cwd: REPO_ROOT,
-      nodir: true,
-      ignore: ["src/channels/**/*.test.ts"],
-    });
+  it("keeps channel production code off bundled-plugin-metadata helpers", () => {
+    const files = listTsFiles("src/channels", { excludeTests: true });
     const offenders = files.filter((file) => {
       if (ALLOWED_CHANNEL_BUNDLED_METADATA_CONSUMERS.has(file)) {
         return false;
@@ -117,13 +129,11 @@ describe("plugin contract boundary invariants", () => {
     expect(offenders).toEqual([]);
   });
 
-  it("keeps contract loaders off hand-built bundled extension paths", async () => {
-    const { globSync } = await import("glob");
-    const files = globSync("src/{plugins,channels}/**/*.ts", {
-      cwd: REPO_ROOT,
-      nodir: true,
-      ignore: ["src/**/*.test.ts"],
-    });
+  it("keeps contract loaders off hand-built bundled extension paths", () => {
+    const files = [
+      ...listTsFiles("src/plugins", { excludeTests: true }),
+      ...listTsFiles("src/channels", { excludeTests: true }),
+    ].toSorted();
     const offenders = files.filter((file) => {
       const source = readFileSync(resolve(REPO_ROOT, file), "utf8");
       return /extensions\/\$\{|\.\.\/\.\.\/\.\.\/\.\.\/extensions\//u.test(source);