fix: honor slack default channel-type account

Author: Takhoffman

extensions/slack/src/channel-type.test.ts

@@ -0,0 +1,64 @@
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import {
+  __resetSlackChannelTypeCacheForTest,
+  resolveSlackChannelType,
+} from "./channel-type.js";
+
+const conversationsInfoMock = vi.fn();
+
+vi.mock("./client.js", () => ({
+  createSlackWebClient: vi.fn(() => ({
+    conversations: {
+      info: conversationsInfoMock,
+    },
+  })),
+}));
+
+describe("resolveSlackChannelType", () => {
+  beforeEach(() => {
+    conversationsInfoMock.mockReset();
+    __resetSlackChannelTypeCacheForTest();
+  });
+
+  it("uses configured defaultAccount for omitted-account cache keys", async () => {
+    const channelId = "C123";
+
+    await expect(
+      resolveSlackChannelType({
+        cfg: {
+          channels: {
+            slack: {
+              enabled: true,
+            },
+          },
+        } as never,
+        channelId,
+      }),
+    ).resolves.toBe("unknown");
+
+    await expect(
+      resolveSlackChannelType({
+        cfg: {
+          channels: {
+            slack: {
+              enabled: true,
+              defaultAccount: "work",
+              accounts: {
+                work: {
+                  botToken: "xoxb-work",
+                  appToken: "xapp-work",
+                  dm: {
+                    groupChannels: [channelId],
+                  },
+                },
+              },
+            },
+          },
+        } as never,
+        channelId,
+      }),
+    ).resolves.toBe("group");
+
+    expect(conversationsInfoMock).not.toHaveBeenCalled();
+  });
+});

extensions/slack/src/channel-type.ts

@@ -14,13 +14,12 @@ export async function resolveSlackChannelType(params: {
   if (!channelId) {
     return "unknown";
   }
-  const cacheKey = `${params.accountId ?? "default"}:${channelId}`;
+  const account = resolveSlackAccount({ cfg: params.cfg, accountId: params.accountId });
+  const cacheKey = `${account.accountId}:${channelId}`;
   const cached = SLACK_CHANNEL_TYPE_CACHE.get(cacheKey);
   if (cached) {
     return cached;
   }
-
-  const account = resolveSlackAccount({ cfg: params.cfg, accountId: params.accountId });
   const groupChannels = normalizeAllowListLower(account.dm?.groupChannels);
   const channelIdLower = channelId.toLowerCase();
   if (
@@ -67,3 +66,7 @@ export async function resolveSlackChannelType(params: {
     return "unknown";
   }
 }
+
+export function __resetSlackChannelTypeCacheForTest(): void {
+  SLACK_CHANNEL_TYPE_CACHE.clear();
+}