test: split provider-shaped core test coverage

Author: steipete

src/commands/doctor-config-flow.test.ts

@@ -2020,6 +2020,7 @@ describe("doctor config flow", () => {
 
   it("does not report repeat talk provider normalization on consecutive repair runs", async () => {
     await withTempHome(async (home) => {
+      const providerId = "acme-speech";
       const configDir = path.join(home, ".openclaw");
       await fs.mkdir(configDir, { recursive: true });
       await fs.writeFile(
@@ -2029,9 +2030,9 @@ describe("doctor config flow", () => {
             talk: {
               interruptOnSpeech: true,
               silenceTimeoutMs: 1500,
-              provider: "elevenlabs",
+              provider: providerId,
               providers: {
-                elevenlabs: {
+                [providerId]: {
                   apiKey: "secret-key",
                   voiceId: "voice-123",
                   modelId: "eleven_v3",

src/commands/doctor/shared/legacy-config-migrate.provider-shapes.test.ts

@@ -0,0 +1,140 @@
+import { describe, expect, it } from "vitest";
+import { migrateLegacyConfig } from "./legacy-config-migrate.js";
+
+describe("legacy migrate provider-shaped config", () => {
+  it("moves messages.tts.<provider> keys into messages.tts.providers", () => {
+    const res = migrateLegacyConfig({
+      messages: {
+        tts: {
+          provider: "elevenlabs",
+          elevenlabs: {
+            apiKey: "test-key",
+            voiceId: "voice-1",
+          },
+        },
+      },
+    });
+
+    expect(res.changes).toContain(
+      "Moved messages.tts.elevenlabs → messages.tts.providers.elevenlabs.",
+    );
+    expect(res.config?.messages?.tts).toEqual({
+      provider: "elevenlabs",
+      providers: {
+        elevenlabs: {
+          apiKey: "test-key",
+          voiceId: "voice-1",
+        },
+      },
+    });
+  });
+
+  it("moves channels.discord.accounts.<id>.voice.tts.edge into providers.microsoft", () => {
+    const res = migrateLegacyConfig({
+      channels: {
+        discord: {
+          accounts: {
+            main: {
+              voice: {
+                tts: {
+                  edge: {
+                    voice: "en-US-JennyNeural",
+                  },
+                },
+              },
+            },
+          },
+        },
+      },
+    });
+
+    expect(res.changes).toContain(
+      "Moved channels.discord.accounts.main.voice.tts.edge → channels.discord.accounts.main.voice.tts.providers.microsoft.",
+    );
+    const mainTts = (
+      res.config?.channels?.discord?.accounts as
+        | Record<string, { voice?: { tts?: Record<string, unknown> } }>
+        | undefined
+    )?.main?.voice?.tts;
+    expect(mainTts?.providers).toEqual({
+      microsoft: {
+        voice: "en-US-JennyNeural",
+      },
+    });
+    expect(mainTts?.edge).toBeUndefined();
+  });
+
+  it("moves plugins.entries.voice-call.config.tts.<provider> keys into providers", () => {
+    const res = migrateLegacyConfig({
+      plugins: {
+        entries: {
+          "voice-call": {
+            config: {
+              tts: {
+                provider: "openai",
+                openai: {
+                  model: "gpt-4o-mini-tts",
+                  voice: "alloy",
+                },
+              },
+            },
+          },
+        },
+      },
+    });
+
+    expect(res.changes).toContain(
+      "Moved plugins.entries.voice-call.config.tts.openai → plugins.entries.voice-call.config.tts.providers.openai.",
+    );
+    const voiceCallTts = (
+      res.config?.plugins?.entries as
+        | Record<string, { config?: { tts?: Record<string, unknown> } }>
+        | undefined
+    )?.["voice-call"]?.config?.tts;
+    expect(voiceCallTts).toEqual({
+      provider: "openai",
+      providers: {
+        openai: {
+          model: "gpt-4o-mini-tts",
+          voice: "alloy",
+        },
+      },
+    });
+  });
+
+  it("does not migrate legacy tts provider keys for unknown plugin ids", () => {
+    const res = migrateLegacyConfig({
+      plugins: {
+        entries: {
+          "third-party-plugin": {
+            config: {
+              tts: {
+                provider: "openai",
+                openai: {
+                  model: "custom-tts",
+                },
+              },
+            },
+          },
+        },
+      },
+    });
+
+    expect(res.changes).toEqual([]);
+    expect(res.config).toBeNull();
+  });
+
+  it("does not migrate extension-owned talk legacy fields during config-load migration", () => {
+    const res = migrateLegacyConfig({
+      talk: {
+        voiceId: "voice-1",
+        modelId: "eleven_v3",
+        outputFormat: "pcm_44100",
+        apiKey: "test-key",
+      },
+    });
+
+    expect(res.config).toBeNull();
+    expect(res.changes).toEqual([]);
+  });
+});

src/commands/doctor/shared/legacy-config-migrate.test.ts

@@ -156,146 +156,6 @@ describe("legacy migrate mention routing", () => {
   });
 });
 
-describe("legacy migrate tts provider shape", () => {
-  it("moves messages.tts.<provider> keys into messages.tts.providers", () => {
-    const res = migrateLegacyConfig({
-      messages: {
-        tts: {
-          provider: "elevenlabs",
-          elevenlabs: {
-            apiKey: "test-key",
-            voiceId: "voice-1",
-          },
-        },
-      },
-    });
-
-    expect(res.changes).toContain(
-      "Moved messages.tts.elevenlabs → messages.tts.providers.elevenlabs.",
-    );
-    expect(res.config?.messages?.tts).toEqual({
-      provider: "elevenlabs",
-      providers: {
-        elevenlabs: {
-          apiKey: "test-key",
-          voiceId: "voice-1",
-        },
-      },
-    });
-  });
-
-  it("moves channels.discord.accounts.<id>.voice.tts.edge into providers.microsoft", () => {
-    const res = migrateLegacyConfig({
-      channels: {
-        discord: {
-          accounts: {
-            main: {
-              voice: {
-                tts: {
-                  edge: {
-                    voice: "en-US-JennyNeural",
-                  },
-                },
-              },
-            },
-          },
-        },
-      },
-    });
-
-    expect(res.changes).toContain(
-      "Moved channels.discord.accounts.main.voice.tts.edge → channels.discord.accounts.main.voice.tts.providers.microsoft.",
-    );
-    const mainTts = (
-      res.config?.channels?.discord?.accounts as
-        | Record<string, { voice?: { tts?: Record<string, unknown> } }>
-        | undefined
-    )?.main?.voice?.tts;
-    expect(mainTts?.providers).toEqual({
-      microsoft: {
-        voice: "en-US-JennyNeural",
-      },
-    });
-    expect(mainTts?.edge).toBeUndefined();
-  });
-
-  it("moves plugins.entries.voice-call.config.tts.<provider> keys into providers", () => {
-    const res = migrateLegacyConfig({
-      plugins: {
-        entries: {
-          "voice-call": {
-            config: {
-              tts: {
-                provider: "openai",
-                openai: {
-                  model: "gpt-4o-mini-tts",
-                  voice: "alloy",
-                },
-              },
-            },
-          },
-        },
-      },
-    });
-
-    expect(res.changes).toContain(
-      "Moved plugins.entries.voice-call.config.tts.openai → plugins.entries.voice-call.config.tts.providers.openai.",
-    );
-    const voiceCallTts = (
-      res.config?.plugins?.entries as
-        | Record<string, { config?: { tts?: Record<string, unknown> } }>
-        | undefined
-    )?.["voice-call"]?.config?.tts;
-    expect(voiceCallTts).toEqual({
-      provider: "openai",
-      providers: {
-        openai: {
-          model: "gpt-4o-mini-tts",
-          voice: "alloy",
-        },
-      },
-    });
-  });
-
-  it("does not migrate legacy tts provider keys for unknown plugin ids", () => {
-    const res = migrateLegacyConfig({
-      plugins: {
-        entries: {
-          "third-party-plugin": {
-            config: {
-              tts: {
-                provider: "openai",
-                openai: {
-                  model: "custom-tts",
-                },
-              },
-            },
-          },
-        },
-      },
-    });
-
-    expect(res.changes).toEqual([]);
-    expect(res.config).toBeNull();
-  });
-});
-
-describe("legacy migrate talk provider shape", () => {
-  it("does not migrate extension-owned talk legacy fields during config-load migration", () => {
-    const res = migrateLegacyConfig({
-      talk: {
-        voiceId: "voice-1",
-        modelId: "eleven_v3",
-        outputFormat: "pcm_44100",
-        apiKey: "test-key",
-      },
-    });
-
-    expect(res.config).toBeNull();
-    expect(res.changes).toEqual([]);
-  });
-});
-
 describe("legacy migrate sandbox scope aliases", () => {
   it("moves agents.defaults.sandbox.perSession into scope", () => {
     const res = migrateLegacyConfig({