perf(secrets): lazy-load web-tools manifest owner lookup

Author: vincentkoc

src/secrets/runtime-web-tools-manifest.runtime.ts

@@ -0,0 +1 @@
+export { resolveManifestContractOwnerPluginId } from "../plugins/manifest-registry.js";

src/secrets/runtime-web-tools.shared.ts

@@ -1,6 +1,6 @@
 import type { OpenClawConfig } from "../config/config.js";
 import { resolveSecretInputRef } from "../config/types.secrets.js";
-import { resolveManifestContractOwnerPluginId } from "../plugins/manifest-registry.js";
+import { createLazyRuntimeNamedExport } from "../shared/lazy-runtime.js";
 import { normalizeOptionalLowercaseString } from "../shared/string-coerce.js";
 import type {
   ResolverContext,
@@ -12,6 +12,11 @@ import type { RuntimeWebDiagnostic, RuntimeWebDiagnosticCode } from "./runtime-w
 export { isRecord } from "./shared.js";
 import { isRecord } from "./shared.js";
 
+const loadResolveManifestContractOwnerPluginId = createLazyRuntimeNamedExport(
+  () => import("./runtime-web-tools-manifest.runtime.js"),
+  "resolveManifestContractOwnerPluginId",
+);
+
 type RuntimeWebWarningCode = Extract<RuntimeWebDiagnosticCode, SecretResolverWarningCode>;
 export type SecretResolutionResult<TSource extends string> = {
   value?: string;
@@ -165,6 +170,7 @@ export async function resolveRuntimeWebProviderSurface<
 ): Promise<RuntimeWebProviderSurface<TProvider>> {
   let configuredBundledPluginId = params.configuredBundledPluginIdHint;
   if (!configuredBundledPluginId && params.rawProvider) {
+    const resolveManifestContractOwnerPluginId = await loadResolveManifestContractOwnerPluginId();
     configuredBundledPluginId = resolveManifestContractOwnerPluginId({
       contract: params.contract,
       value: params.rawProvider,
@@ -187,6 +193,7 @@ export async function resolveRuntimeWebProviderSurface<
     configuredBundledPluginId = undefined;
   }
   if (params.rawProvider && !configuredBundledPluginId) {
+    const resolveManifestContractOwnerPluginId = await loadResolveManifestContractOwnerPluginId();
     configuredBundledPluginId = resolveManifestContractOwnerPluginId({
       contract: params.contract,
       value: params.rawProvider,

src/secrets/runtime-web-tools.test.ts

@@ -37,11 +37,11 @@ const {
 const { resolveManifestContractPluginIdsByCompatibilityRuntimePathMock } = vi.hoisted(() => ({
   resolveManifestContractPluginIdsByCompatibilityRuntimePathMock: vi.fn(() => ["brave"]),
 }));
-const { resolveManifestContractOwnerPluginIdMock, manifestRegistryActual } = vi.hoisted(() => ({
+const { resolveManifestContractOwnerPluginIdMock, runtimeManifestActual } = vi.hoisted(() => ({
   resolveManifestContractOwnerPluginIdMock: vi.fn(),
-  manifestRegistryActual: {
+  runtimeManifestActual: {
     resolveManifestContractOwnerPluginId: undefined as
-      | typeof import("../plugins/manifest-registry.js").resolveManifestContractOwnerPluginId
+      | typeof import("./runtime-web-tools-manifest.runtime.js").resolveManifestContractOwnerPluginId
       | undefined,
   },
 }));
@@ -81,16 +81,25 @@ vi.mock("../plugins/manifest-registry.js", async () => {
   const actual = await vi.importActual<typeof import("../plugins/manifest-registry.js")>(
     "../plugins/manifest-registry.js",
   );
-  manifestRegistryActual.resolveManifestContractOwnerPluginId =
+  return {
+    ...actual,
+    resolveManifestContractPluginIdsByCompatibilityRuntimePath:
+      resolveManifestContractPluginIdsByCompatibilityRuntimePathMock,
+  };
+});
+
+vi.mock("./runtime-web-tools-manifest.runtime.js", async () => {
+  const actual = await vi.importActual<typeof import("./runtime-web-tools-manifest.runtime.js")>(
+    "./runtime-web-tools-manifest.runtime.js",
+  );
+  runtimeManifestActual.resolveManifestContractOwnerPluginId =
     actual.resolveManifestContractOwnerPluginId;
   resolveManifestContractOwnerPluginIdMock.mockImplementation(
     actual.resolveManifestContractOwnerPluginId,
   );
   return {
     ...actual,
     resolveManifestContractOwnerPluginId: resolveManifestContractOwnerPluginIdMock,
-    resolveManifestContractPluginIdsByCompatibilityRuntimePath:
-      resolveManifestContractPluginIdsByCompatibilityRuntimePathMock,
   };
 });
 
@@ -313,7 +322,7 @@ describe("runtime web tools resolution", () => {
     resolveBundledWebFetchProvidersFromPublicArtifactsMock.mockClear();
     resolveManifestContractOwnerPluginIdMock.mockReset();
     resolveManifestContractOwnerPluginIdMock.mockImplementation(
-      manifestRegistryActual.resolveManifestContractOwnerPluginId!,
+      runtimeManifestActual.resolveManifestContractOwnerPluginId!,
     );
     resolveManifestContractOwnerPluginIdMock.mockClear();
     resolveManifestContractPluginIdsByCompatibilityRuntimePathMock.mockClear();