fix: fix issue with eslint

Author: Alexandrbig1

src/config/passport.config.js

@@ -3,7 +3,6 @@ import pkg from 'passport-google-oauth20';
 const GoogleStrategy = pkg.Strategy || pkg;
 import User from '../models/user.model.js';
 import jwt from 'jsonwebtoken';
-import crypto from 'crypto';
 import { sendPendingLinkEmail } from '../utils/email.util.js';
 
 // helper to generate JWT (used by controller as well)
@@ -30,7 +29,8 @@ const jwtSecret = process.env.JWT_SECRET || '';
 if (process.env.NODE_ENV !== 'test') {
   // require at least 32 bytes (64 hex chars) for HMAC secrets
   if (typeof jwtSecret !== 'string' || jwtSecret.length < 64) {
-    throw new Error('Weak or missing JWT_SECRET. Use a strong random secret (e.g. `node -e \"console.log(require(\\'crypto\\').randomBytes(64).toString(\\'hex\\'))\"`) and set it in environment variables.');
+    const genCmd = `node -e "console.log(require('crypto').randomBytes(64).toString('hex'))"`;
+    throw new Error(`Weak or missing JWT_SECRET. Use a strong random secret (for example run: ${genCmd}) and set it in environment variables.`);
   }
   // optional: ensure it's not a default placeholder
   if (/replace_|your_|changeme/i.test(jwtSecret)) {

src/controllers/auth.controller.js

@@ -3,13 +3,9 @@ import User from '../models/user.model.js';
 import { generateToken } from '../config/passport.config.js';
 import crypto from 'crypto';
 
-// WARNING: cookie-parser middleware must be enabled in app.js for the state cookie to work
-// e.g. app.use(cookieParser());
-
 // Redirect to Google OAuth (generates a per-request state stored in an httpOnly cookie)
 export const googleAuth = (req, res, next) => {
   const state = crypto.randomBytes(16).toString('hex');
-  // store state in an httpOnly cookie for CSRF protection, short lived
   res.cookie('oauth_state', state, {
     httpOnly: true,
     secure: process.env.NODE_ENV === 'production',
@@ -37,7 +33,6 @@ export const googleCallback = (req, res, next) => {
       res.clearCookie('oauth_state');
       return res.status(403).json({ success: false, message: 'Invalid OAuth state' });
     }
-    // clear cookie early
     res.clearCookie('oauth_state');
 
     passport.authenticate('google', { session: false }, async (err, user, info) => {
@@ -69,7 +64,6 @@ export const googleCallback = (req, res, next) => {
           return res.redirect(`${frontend}/auth/success#token=${token}`);
         }
 
-        // return safe public user view (include email for owner)
         return res.json({
           success: true,
           message: 'Authentication successful',
@@ -91,59 +85,41 @@ export const googleCallback = (req, res, next) => {
 export const getProfile = async (req, res) => {
   try {
     const user = await User.findById(req.user.userId);
-    
     if (!user) {
-      return res.status(404).json({
-        success: false,
-        message: 'User not found'
-      });
+      return res.status(404).json({ success: false, message: 'User not found' });
     }
-    
-    // return public view including email because requester is the owner (authenticated)
-    res.json({
-      success: true,
-      user: user.toPublic(true)
-    });
+    res.json({ success: true, user: user.toPublic(true) });
   } catch (error) {
     console.error('Get profile error:', error?.stack || error);
-    res.status(500).json({
-      success: false,
-      message: 'Failed to get user profile'
-    });
+    return res.status(500).json({ success: false, message: 'Failed to get user profile' });
   }
 };
 
 // Logout (invalidate tokens for this user by bumping tokenVersion)
 export const logout = async (req, res) => {
   try {
-    // increment tokenVersion to revoke all existing tokens for this user
     await User.incrementTokenVersion(req.user.userId);
-    // clear token cookie if used
     if (process.env.SEND_TOKEN_COOKIE === 'true') {
       res.clearCookie('token', { httpOnly: true, sameSite: 'lax', secure: process.env.NODE_ENV === 'production' });
     }
-    return res.json({
-      success: true,
-      message: 'Logout successful. Tokens invalidated on server.'
-    });
+    return res.json({ success: true, message: 'Logout successful. Tokens invalidated on server.' });
   } catch (error) {
-    console.error('Logout error:', error);
+    console.error('Logout error:', error?.stack || error);
     return res.status(500).json({ success: false, message: 'Failed to logout' });
   }
 };
 
-// Refresh token: ensure tokenVersion still matches before issuing new token matches before issuing new token
-export const refreshToken = async (req, res) => {const refreshToken = async (req, res) => {
-  try {ry {
-    const user = await User.findById(req.user.userId).select('-__v');  const user = await User.findById(req.user.userId).select('-__v');
-    if (!user) {    if (!user) {
-      return res.status(404).json({ success: false, message: 'User not found' });not found' });
+// Refresh token: issue a new JWT if the authenticated user's tokenVersion matches current
+export const refreshToken = async (req, res) => {
+  try {
+    const user = await User.findById(req.user.userId).select('-__v');
+    if (!user) {
+      return res.status(404).json({ success: false, message: 'User not found' });
     }
-    // issue new JWT reflecting current tokenVersionissue new JWT reflecting current tokenVersion
     const token = generateToken(user);
-    res.json({ success: true, message: 'Token refreshed successfully', token });d successfully', token });
+    return res.json({ success: true, message: 'Token refreshed successfully', token });
   } catch (error) {
-    console.error('Refresh token error:', error?.stack || error);ack || error);
+    console.error('Refresh token error:', error?.stack || error);
     return res.status(500).json({ success: false, message: 'Failed to refresh token' });
   }
 };

src/controllers/cart.controller.js

@@ -26,6 +26,7 @@ export const getCart = async (req, res, next) => {
       data: cart ? cart.items : [],
     });
   } catch (err) {
+    console.error('Cart controller error (getCart):', err);
     next(new HttpException(500, 'Failed to fetch cart'));
   }
 }
@@ -66,6 +67,7 @@ export const addToCart = async (req, res, next) => {
 
     return res.status(200).json({ success: true, data: cart.items });
   } catch (err) {
+    console.error('Cart controller error (addToCart):', err);
     next(new HttpException(500, 'Failed to add to cart'));
   }
 }
@@ -104,6 +106,7 @@ export const updateCartItem = async (req, res, next) => {
 
     return res.status(200).json({ success: true, data: cart.items });
   } catch (err) {
+    console.error('Cart controller error (updateCartItem):', err);
     next(new HttpException(500, 'Failed to update cart item'));
   }
 }
@@ -131,6 +134,7 @@ export const removeFromCart = async (req, res, next) => {
 
     return res.status(200).json({ success: true, data: cart.items });
   } catch (err) {
+    console.error('Cart controller error (removeFromCart):', err);
     next(new HttpException(500, 'Failed to remove from cart'));
   }
 }

src/controllers/collection.controller.js

@@ -27,6 +27,7 @@ export const getCollectionProducts = async (req, res, next) => {
 
     return res.status(200).json({ collections: name, products });
   } catch (err) {
+    console.error('Collection controller error (getCollectionProducts):', err);
     next(new HttpException(500, "Failed to fetch collections products"));
   }
 }

src/middleware/auth.middleware.js

@@ -92,7 +92,7 @@ const optionalAuth = async (req, res, next) => {
         return next();
       }
       req.user = decoded;
-    } catch (err) {
+    } catch {
       // invalid or expired token -> treat as unauthenticated
       req.user = null;
     }

src/middleware/error-handler.middleware.js

@@ -8,9 +8,9 @@
  * @param {Response} res - Express response object.
  * @param {Function} _next - Express next middleware function (unused).
  */
-export default function errorHandler(err, req, res, next) {
-
-  console.error("Error:", err.message);
+export default function errorHandler(err, _req, res) {
+  // Log full error server-side (stack if available)
+  console.error("Error:", err.stack || err);
 
   const status = err?.statusCode ? err.statusCode : 500;
   const response = {
@@ -19,7 +19,7 @@ export default function errorHandler(err, req, res, next) {
   };
 
   // stack trace (only in development)
-  if(process.env.NODE_ENV == 'development') response.stack = err.stack;
+  if (process.env.NODE_ENV === 'development') response.stack = err.stack;
 
   res.status(status).json(response);
 }

src/middleware/notFound.middleware.js

@@ -1,10 +1,8 @@
-import express from 'express'
-
-const notFound = (req,res,next) =>{
-    res.status(404).json({
-        success: false,
-        message: "Route not found"
-    })
-} 
+const notFound = (req, res) => {
+  res.status(404).json({
+    success: false,
+    message: "Route not found"
+  });
+};
 
 export default notFound;