fix: update sorting options to use 'Featured' instead of 'Best Selling'#104
Merged
Alexandrbig1 merged 1 commit intoOct 10, 2025
Merged
Conversation
Alexandrbig1
approved these changes
Oct 10, 2025
Contributor
Alexandrbig1
left a comment
Alexandrbig1
left a comment
There was a problem hiding this comment.
Thank you for your contribution, and congrats on your PR being approved!
We’re excited to have your work as part of Open Code Chicago’s Hacktoberfest 2025 project.
Alexandrbig1
added
frontend
github-project-automation
Bot
moved this to Done
in CoreX E-Commerce — Hacktoberfest 2025
Contributor
|
@AparAgarwal, please check this issue: when opening the "Filter" tab it automatically closes on scroll. The tab should remain open until the user clicks the "x" button or clicks outside the filter menu. Also verify the design: the filter header must include an "x" close button and a top title that reads "Sort by".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the product sorting options to replace "Best Selling" with "Featured" as the default and primary sort option in both the UI and sorting logic. The changes ensure consistency in naming and default behavior across the relevant components.
Sorting Option Updates:
SORT_OPTIONSarray inSortDropdown.jsx, making "Featured" the new default sort option.sortByprop in theSortDropdowncomponent from'best_selling'to'featured'.Sorting Logic Adjustments:
Productspage from'best_selling:desc'to'featured:desc'and updated the corresponding comment to reflect the change. The sorting logic remains a placeholder that preserves the original order.