Skip to content

Commit 0022a70

Browse files
committed
Fixes subpart of #549
1 parent 9046a40 commit 0022a70

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

server/src/main/java/invite/mail/MailBox.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public void sendInviteMail(Provisionable provisionable, Invitation invitation,
104104
String url = intendedAuthority.equals(Authority.GUEST) ? welcomeUrl : clientUrl;
105105

106106
variables.put("url", String.format("%s/invitation/accept?hash=%s", url, invitation.getHash()));
107-
variables.put("useEduID", invitation.isEduIDOnly() && invitation.getIntendedAuthority().equals(Authority.GUEST));
107+
variables.put("useEduID", invitation.isEduIDOnly());
108108

109109
sendMail(String.format("invitation_%s", language.name()),
110110
title,

server/src/test/java/invite/mail/MailBoxTest.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class MailBoxTest extends AbstractMailTest {
2323

2424
@Test
2525
void sendInviteMail() {
26-
String htmlContent = doSendInviteMail(true, Authority.INVITER);
26+
String htmlContent = doSendInviteMail(false, Authority.INVITER);
2727

2828
assertTrue(htmlContent.contains("Wiki EN"));
2929
assertTrue(htmlContent.contains("You accept the role(s) by logging in with SURFconext."));
@@ -39,6 +39,15 @@ void sendInviteMailForEduIDOnly() {
3939
assertTrue(htmlContent.contains("You accept the role(s) by logging in with eduID"));
4040
}
4141

42+
@Test
43+
void sendInviteMailForEduIDOnlyForNonGuests() {
44+
String htmlContent = doSendInviteMail(true, Authority.MANAGER);
45+
46+
assertTrue(htmlContent.contains("Wiki EN"));
47+
assertFalse(htmlContent.contains("You accept the role(s) by logging in with SURFconext"));
48+
assertTrue(htmlContent.contains("You accept the role(s) by logging in with eduID"));
49+
}
50+
4251
private String doSendInviteMail(boolean eduIDOnly, Authority intendedAuthority) {
4352
User user = new User(false, "eppn", "sub", "example.com", "John", "Doe", "jdoe@example.com");
4453
Invitation invitation = new Invitation(intendedAuthority,

0 commit comments

Comments
 (0)