Skip to content

Commit 07190a4

Browse files
committed
Fixes #649
1 parent a407563 commit 07190a4

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

client/src/__tests__/validations/regExps.test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ describe('regExps', () => {
1010
it('Emails formats', () => {
1111
expect(validEmailRegExp.test("aa")).toBeFalsy();
1212
expect(validEmailRegExp.test("a!@a.c")).toBeFalsy();
13+
expect(validEmailRegExp.test("aa@abc..c")).toBeFalsy();
1314
expect(validEmailRegExp.test("a!@a.c@")).toBeFalsy();
1415

1516
expect(validEmailRegExp.test("a@a")).toBeTruthy();

client/src/pages/InvitationForm.jsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -323,9 +323,6 @@ export const InvitationForm = () => {
323323
pinnedEmails={[]}
324324
removeMail={removeMail}
325325
required={true}
326-
maxEmails={null} //TODO is there a internal placeholder identifier? then one.
327-
// See https://github.com/OpenConext/OpenConext-Invite/issues/540
328-
maxEmailsMessage={"TODO : localize Not allowed to add more then one email with external identifier"}
329326
error={!initial && isEmpty(invitation.invites)}/>
330327

331328
{(!initial && isEmpty(invitation.invites)) &&

client/src/pages/Role.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,9 @@ export const Role = () => {
184184
</span>}
185185
{!isEmpty(institutionAdmins) && <span dangerouslySetInnerHTML={{
186186
__html: DOMPurify.sanitize(I18n.t("role.institutionAdmin", {
187-
names: splitListSemantically(institutionAdmins.map(u => u.name), I18n.t("forms.and"))
187+
names: splitListSemantically(
188+
institutionAdmins.map(u => `<a href="mailto:${u.email}">${u.name}</a>`),
189+
I18n.t("forms.and"))
188190
}))
189191
}}/>}
190192
</div>

client/src/validations/regExps.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const validEmailRegExp = /^[+a-zA-Z0-9._-]+@[a-zA-Z0-9.-]+\.?[a-zA-Z]*$/;///^\S+@\S+$/;
1+
export const validEmailRegExp = /^[+a-zA-Z0-9._-]+@[a-zA-Z0-9]+([.-][a-zA-Z0-9]+)*\.?[a-zA-Z]*$/;///^\S+@\S+$/;
22

33
export const validUrlRegExp = /(https?|ssh|ftp):\/\/(((www\.)?[-a-zA-Z0-9@:%._+~#=]{1,256}\.?[a-z]{0,63})|(localhost))\b([-a-zA-Z0-9@:%_+.~#?&/=]*)/i
44

0 commit comments

Comments
 (0)