Bugfix for #398 - which compared ARP source wrong

Author: oharsta

server/src/main/java/invite/manage/Manage.java

@@ -107,7 +107,9 @@ default Map<String, Object> transformProvider(Map<String, Object> provider) {
                 if (CollectionUtils.isEmpty(isMemberOf)) {
                     application.put("receivesMemberships", false);
                 } else {
-                    boolean receivesVootMemberships = isMemberOf.stream().anyMatch(m -> m.get("source") == "voot");
+                    boolean receivesVootMemberships = isMemberOf.stream()
+                            .map(m -> m.getOrDefault("source", "nope"))
+                            .anyMatch(source -> source.equals("voot") || source.equals("invite"));
                     application.put("receivesMemberships", receivesVootMemberships);
                 }
             }

server/src/main/resources/manage/saml20_sp.json

@@ -11,6 +11,18 @@
         "OrganizationName:en": "SURF bv",
         "coin:institution_guid": "ad93daef-0911-e511-80d0-005056956c1a",
         "coin:application_url": "https://default-url-wiki.org"
+      },
+      "arp": {
+        "enabled": true,
+        "attributes": {
+          "urn:mace:dir:attribute-def:isMemberOf": [
+            {
+              "value": "*",
+              "source": "voot",
+              "motivation": ""
+            }
+          ]
+        }
       }
     }
   },

server/src/test/java/invite/api/UserControllerTest.java

@@ -137,7 +137,11 @@ void institutionAdminProvision() throws Exception {
         assertNotNull(user.getId());
         assertTrue(user.isInstitutionAdmin());
         assertEquals(ORGANISATION_GUID, user.getOrganizationGUID());
-        assertEquals(4, user.getApplications().size());
+        List<Map<String, Object>> applications = user.getApplications();
+        assertEquals(4, applications.size());
+        Map<String, Object> wiki = applications.stream().filter(m -> m.get("entityid").equals("https://wiki"))
+                .findFirst().get();
+        assertTrue((Boolean) wiki.get("receivesMemberships"));
 
         Map res = given()
                 .when()