Fixes #655

Author: oharsta

server/src/main/java/invite/provision/ProvisioningServiceDefault.java

@@ -173,18 +173,26 @@ public void updateUserRequest(User user) {
                 .toList();
         //Provision the user to all provisionings in Manage where the user is known
         provisionings.forEach(provisioning -> {
-            if (this.hasEvaHook(provisioning)) {
-                RequestEntity requestEntity = this.evaClient.updateUserRequest(provisioning, user);
-                this.doExchange(requestEntity, APIType.USER_API, mapParameterizedTypeReference, provisioning);
-            } else if (this.hasScimHook(provisioning)) {
-                Optional<RemoteProvisionedUser> provisionedUserOptional =
-                        this.remoteProvisionedUserRepository.findByManageProvisioningIdAndUser(provisioning.getId(), user);
-                provisionedUserOptional.ifPresent(remoteProvisionedUser -> {
-                    UserRequest userRequest = new UserRequest(user, provisioning, remoteProvisionedUser.getRemoteIdentifier());
-                    this.resolveInstitutionalEduID(user, provisioning, userRequest);
-                    String userRequestJson = prettyJson(userRequest);
-                    this.updateRequest(provisioning, userRequestJson, APIType.USER_API, remoteProvisionedUser.getRemoteIdentifier(), HttpMethod.PUT);
-                });
+            try {
+                if (this.hasEvaHook(provisioning)) {
+                    RequestEntity requestEntity = this.evaClient.updateUserRequest(provisioning, user);
+                    this.doExchange(requestEntity, APIType.USER_API, mapParameterizedTypeReference, provisioning);
+                } else if (this.hasScimHook(provisioning)) {
+                    Optional<RemoteProvisionedUser> provisionedUserOptional =
+                            this.remoteProvisionedUserRepository.findByManageProvisioningIdAndUser(provisioning.getId(), user);
+                    provisionedUserOptional.ifPresent(remoteProvisionedUser -> {
+                        UserRequest userRequest = new UserRequest(user, provisioning, remoteProvisionedUser.getRemoteIdentifier());
+                        this.resolveInstitutionalEduID(user, provisioning, userRequest);
+                        String userRequestJson = prettyJson(userRequest);
+                        this.updateRequest(provisioning, userRequestJson, APIType.USER_API, remoteProvisionedUser.getRemoteIdentifier(), HttpMethod.PUT);
+                    });
+                }
+            } catch (RuntimeException e) {
+                //We choose to ignore these, because one remote provisioning errors should not stop other provisionings
+                LOG.error(String.format("Error in updateUserRequest for provisioning %s for user %s",
+                                provisioning.getEntityId(), user.getEmail())
+                        , e);
+
             }
         });
     }

server/src/test/java/invite/provision/ProvisioningServiceDefaultTest.java

@@ -126,15 +126,8 @@ void updateUserRequestWithEduIDProvisioningError() throws JsonProcessingExceptio
         remoteProvisionedUserRepository.save(remoteProvisionedUser);
         this.stubForManageProvisioning(List.of("1", "4", "5"));
         this.stubForUpdateScimUser();
-        try {
-            provisioningService.updateUserRequest(user);
-            fail("Expected RemoteException");
-        } catch (RemoteException e) {
-            assertTrue(e.getMessage().contains("Error in provisionEduid"));
-            assertEquals(HttpStatus.BAD_REQUEST, e.getStatusCode());
-            assertNotNull(e.getReference());
-        }
-
+        //RuntTime exceptions are caught
+        provisioningService.updateUserRequest(user);
     }
 
     @Test