259 Remove todo's and fix lint

Author: Liemine

client/eslint.config.mjs

@@ -18,12 +18,11 @@ export default defineConfig([
   reactHooks.configs.flat.recommended,
   {
     rules: {
-      // ToDo check rules that are off and warn
       "react/prop-types": "off",
       "react/no-children-prop": "off",
       'react-hooks/exhaustive-deps': 'warn',
       "react/react-in-jsx-scope" : "off",
-      "react-hooks/set-state-in-effect": "off",
+      "react-hooks/set-state-in-effect": "warn",
       "react-hooks/immutability":"off"
     },
   },

client/src/__tests__/utils/Utils.test.js

@@ -12,12 +12,5 @@ describe('Utils', () => {
             }],
             "id");
         expect(res.length).toEqual(3);
-
-        const resId = distinctValues([{id: 1, val: "val1"}, {id: 1, val: "valX"}, {id: 2, val: "val2"}, {
-                id: 3,
-                val: "val3"
-            }],
-            "id");
-        expect(res.length).toEqual(3);
     });
 });

client/src/components/Header.jsx

@@ -7,7 +7,7 @@ import {useAppStore} from "../stores/AppStore";
 import I18n from "../locale/I18n";
 
 export const Header = () => {
-    const {user, config} = useAppStore(state => state);
+    const {user} = useAppStore(state => state);
 
     const actions = []
 
@@ -21,7 +21,6 @@ export const Header = () => {
                 </Link>
                 {(user && user.id) &&
                     <UserMenu user={user}
-                              config={config}
                               actions={actions}
                     />
                 }

client/src/components/UserMenu.jsx

@@ -9,7 +9,7 @@ import {logout} from "../api";
 import {AUTHORITIES, highestAuthority} from "../utils/UserRole";
 
 
-export const UserMenu = ({user, config, actions}) => {
+export const UserMenu = ({user, actions}) => {
     const navigate = useNavigate();
 
     const [dropDownActive, setDropDownActive] = useState(false);

client/src/pages/Application.jsx

@@ -73,7 +73,6 @@ export const Application = () => {
             header: "",
             mapper: role => role.unknownInManage ? <div className="role-icon unknown-in-manage"><AlertLogo/></div> :
                 <div className="role-icon">
-                    {/*ToDo check if this role.log works*/}
                     {typeof role.logo === "string" ? <img src={role.logo} alt="logo"/> : role.logo}
                 </div>
         },

client/src/pages/RoleForm.jsx

@@ -525,7 +525,7 @@ export const RoleForm = () => {
                 {!isEmpty(deletedUserRoles) && <div className="consequences">
                     <p>{I18n.t("roles.consequences.info")}</p>
                     <ul>
-                        {deletedUserRoles.slice(0, CUT_OFF_DELETED_USER).map(userRole => <li>
+                        {deletedUserRoles.slice(0, CUT_OFF_DELETED_USER).map((userRole, index) => <li key={index}>
                             {I18n.t("roles.consequences.userInfo", {
                                 name: userRole.userInfo.name,
                                 authority: I18n.t(`access.${userRole.authority}`),

client/src/stores/AppStore.js

@@ -25,10 +25,4 @@ export const useAppStore = create(set => ({
     clearFlash: () => set({flash: {}}),
     //[{path: "/roles/4", value: role.name}]
     breadcrumbPath: []
-}));
-
-export const useManageStore = create(set => ({
-    providers: [],
-    provisionings: [],
-    providerById: {}
 }));

client/src/tabs/Applications.jsx

@@ -50,7 +50,6 @@ const Applications = () => {
             header: "",
             nonSortable: true,
             mapper: application => <div className="role-icon">
-                {/*ToDo check if this works*/}
                 {typeof application.logo === "string" ? <img src={application.logo} alt="logo"/> : application.logo}
             </div>
         },

client/src/tabs/Cron.jsx

@@ -43,7 +43,7 @@ export const Cron = () => {
             </div>
             {!isEmpty(mailResults) &&
                 <div className="cron-results">
-                    {mailResults["mails"].map(mail => <div className="mail-content">
+                    {mailResults["mails"].map((mail, index) => <div key={index} className="mail-content">
                         <p dangerouslySetInnerHTML={{
                             __html: DOMPurify.sanitize(mail)
                         }}/>

client/src/tabs/Roles.jsx

@@ -89,7 +89,6 @@ export const Roles = () => {
         const logo = institution["logo"]
         return (
             <div className="institution-admin-welcome">
-                {/*ToDo check if this works*/}
                 {logo ? <img src={logo} alt="logo"/> : <VoidImage/>}
                 <p>{I18n.t("institutionAdmin.welcome", {name: name})}</p>
                 <Button txt={I18n.t("institutionAdmin.create")}
@@ -107,7 +106,6 @@ export const Roles = () => {
             header: "",
             mapper: role => role.unknownInManage ? <div className="role-icon unknown-in-manage"><AlertLogo/></div> :
                 <div className="role-icon">
-                    {/*ToDo check if this works*/}
                     {typeof role.logo === "string" ? <img src={role.logo} alt="logo"/> : role.logo}
                 </div>
         },