259 Add eslint

Author: Liemine

client/eslint.config.mjs

@@ -0,0 +1,31 @@
+import js from "@eslint/js";
+import globals from "globals";
+import pluginReact from "eslint-plugin-react";
+import reactHooks from 'eslint-plugin-react-hooks';
+import { defineConfig } from "eslint/config";
+
+export default defineConfig([
+  {
+    files: ["**/*.{js,mjs,cjs,jsx}"],
+    plugins: {
+      js ,
+      'react-hooks': reactHooks
+    },
+    extends: ["js/recommended"],
+    languageOptions: { globals: globals.browser }
+  },
+  pluginReact.configs.flat.recommended, // React config first
+  reactHooks.configs.flat.recommended,
+  {
+    rules: {
+      // ToDo check rules that are off and warn
+      "react/prop-types": "off",
+      "react/no-children-prop": "off",
+      'react-hooks/exhaustive-deps': 'warn',
+      "react/react-in-jsx-scope" : "off",
+      "react-hooks/set-state-in-effect": "off",
+      "react-hooks/immutability":"off"
+    },
+  },
+
+]);

client/package.json

@@ -34,9 +34,14 @@
   },
   "devDependencies": {
     "@babel/plugin-proposal-private-property-in-object": "^7.21.11",
+    "@eslint/js": "^9.39.1",
     "@testing-library/jest-dom": "^6.7.0",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
+    "eslint": "^9.39.1",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^7.0.1",
+    "globals": "^16.5.0",
     "http-proxy-middleware": "^3.0.5",
     "nth-check": "^2.1.1",
     "react-json-view-lite": "^2.4.2",

client/src/pages/Login.jsx

@@ -22,7 +22,7 @@ export const Login = () => {
         if (buttonRef && buttonRef.current) {
             buttonRef.current.focus();
         }
-    }, []) // eslint-disable-line react-hooks/exhaustive-deps
+    }, [])  
 
 
     const doLogin = () => {

client/src/pages/UserTokens.jsx

@@ -16,7 +16,7 @@ export const UserTokens = () => {
             ]
         });
 
-    }, []);// eslint-disable-line react-hooks/exhaustive-deps
+    }, []); 
 
     return (
         <div className="mod-tokens">

client/src/tabs/Roles.jsx

@@ -52,7 +52,7 @@ export const Roles = () => {
             setRoles(newRoles);
             setSearching(false);
         }
-    }, [user, paginationQueryParams]);// eslint-disable-line react-hooks/exhaustive-deps
+    }, [user, paginationQueryParams]); 
 
     const openRole = (e, role) => {
         const id = role.isUserRole ? role.role.id : role.id;

client/src/tabs/Users.jsx

@@ -35,7 +35,7 @@ export const Users = () => {
                     setSearching(false);
                 });
         },
-        [paginationQueryParams]);// eslint-disable-line react-hooks/exhaustive-deps
+        [paginationQueryParams]); 
 
     const openUser = (e, user) => {
         const path = `/profile/${user.id}`

client/src/utils/Utils.js

@@ -18,7 +18,7 @@ export function isEmpty(obj) {
         return obj.trim().length === 0;
     }
     if (obj && obj.getTime) {
-        // eslint-disable-next-line
+         
         return obj.getTime() !== obj.getTime();
     }
     if (typeof obj === "object") {