Part of #656

You may not invite users from Invite GUI for a CRM role
Implement users_unique_crm_contact_profile

Author: oharsta

client/src/pages/InvitationForm.jsx

@@ -370,7 +370,8 @@ export const InvitationForm = () => {
 
                 {(!isInviter && !skipRoles) && <>
                     <SelectField value={selectedRoles}
-                                 options={roles.filter(role => !selectedRoles.find(r => r.value === role.value))}
+                                 options={roles.filter(role => !selectedRoles.find(r => r.value === role.value)
+                                 && isEmpty(role.crmRoleId))}
                                  name={I18n.t("invitations.roles")}
                                  toolTip={I18n.t("tooltips.rolesTooltip")}
                                  isMulti={true}

client/src/tabs/Invitations.jsx

@@ -327,7 +327,8 @@ export const Invitations = ({
                   defaultSort="email"
                   columns={columns}
                   newLabel={I18n.t("invitations.newInvite")}
-                  showNew={!!role && isUserAllowed(AUTHORITIES.MANAGER, user) && !role.unknownInManage}
+                  showNew={!!role && isUserAllowed(AUTHORITIES.MANAGER, user) && !role.unknownInManage
+                      && isEmpty(role.crmRoleId)}
                   newEntityFunc={role ? () => navigate("/invitation/new", {state: role.id}) : null}
                   customNoEntities={I18n.t(`invitations.noResults`)}
                   loading={false}

client/src/tabs/UserRoles.jsx

@@ -385,7 +385,8 @@ export const UserRoles = ({role, guests}) => {
                   defaultSort="name"
                   columns={columns}
                   newLabel={I18n.t(guests ? "invitations.newGuest" : isUserAllowed(AUTHORITIES.INSTITUTION_ADMIN, user) ? "invitations.new" : "invitations.newInvitation")}
-                  showNew={isUserAllowed(AUTHORITIES.MANAGER, user) && !role.unknownInManage}
+                  showNew={isUserAllowed(AUTHORITIES.MANAGER, user) && !role.unknownInManage
+                      && isEmpty(role.crmRoleId)}
                   newEntityFunc={() => navigate(`/invitation/new?maintainer=${guests === false}`, {state: role.id})}
                   customNoEntities={I18n.t(`userRoles.noResults`)}
                   loading={false}

server/src/test/java/invite/api/InvitationControllerTest.java

@@ -108,6 +108,41 @@ void newInvitation() throws Exception {
         assertEquals(2, ((List) results.get("recipientInvitationURLs")).size());
     }
 
+    @Test
+    void invitationForCrmRoleNotAllowed() throws Exception {
+        AccessCookieFilter accessCookieFilter = openIDConnectFlow("/api/v1/users/login", MANAGE_SUB);
+        Role research = roleRepository.findByName("Research").get();
+        research.setCrmRoleId(UUID.randomUUID().toString());
+        roleRepository.save(research);
+
+        InvitationRequest invitationRequest = new InvitationRequest(
+                Authority.GUEST,
+                "Message",
+                Language.en,
+                true,
+                false,
+                null,
+                false,
+                false,
+                List.of("new@new.nl"),
+                List.of(new Invite("new2@new.nl", "placeholder-1")),
+                List.of(research.getId()),
+                null,
+                Instant.now().plus(365, ChronoUnit.DAYS),
+                Instant.now().plus(12, ChronoUnit.DAYS));
+
+        given()
+                .when()
+                .filter(accessCookieFilter.cookieFilter())
+                .accept(ContentType.JSON)
+                .header(accessCookieFilter.csrfToken().getHeaderName(), accessCookieFilter.csrfToken().getToken())
+                .contentType(ContentType.JSON)
+                .body(invitationRequest)
+                .post("/api/v1/invitations")
+                .then()
+                .statusCode(HttpStatus.NOT_FOUND.value());
+    }
+
     @Test
     void newInvitationNL() throws Exception {
         //Because the user is changed and provisionings are queried